On Mon, Sep 04, 2006 at 11:14:51AM -0700, Russ Allbery wrote:
David Härdeman <[EMAIL PROTECTED]> writes:
the attached patch changes the slapd init.d script(s) to use lsb
logging functions.
This doesn't really look like an improvement to me. We'd be replacing
wrapped messages with unwrapped messages, losing some detail from one of
the messages, and I don't think really improving the output for the user.
Well, if the lsb scripts are not able to wrap long lines, a bug should
be filed against lsb-base.
As for the lost detail, that was intentional. Slapd is the only init script
of the 50 or so that I've investigated so far that prints half a man page
instead of a one line error message.
I do agree that I should have sent the de-verbosification as a separate
patch though :)
The basic idea of the LSB logging functions is a good one, but I've been
rather unsatisfied by how they look in practice. One of the main things
they do is render any error message much more confusing because it gets
concatenated with status messages all on the same line. There should be a
better way, although I'm not quite sure what -- maybe something that
intercepts stderr output so that it can add appropriate newlines, wrap
error messages, and make things more readable.
I think the philosophy of lsb logging (and indeed most other non-slapd
init scripts) is somewhat different. More along the lines of just
printing "Starting devfoo....failed" and leaving a more detailed error
description somewhere else (e.g. the man page or in syslog).
Regards,
David
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
