On Fri, Aug 25, 2006 at 09:59:39PM +0200, Peter Eisentraut wrote:
> I just generated one of these mails for myself, and I think it's
> perfectly reasonably worded.  The subject "Segfault in Samba",
> however, could be worded more neutrally.  How about this:

I think this might be a little /too/ neutral... :)  Can we say perhaps
"Segfault or panic in Samba" for the subject, or "Segfault or assertion", so
it's a little more explicit what kind of problem there was?

A pointer to the logs might also be a good idea to include, since Samba
frequently generates better backtraces for itself than gdb does.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
[EMAIL PROTECTED]                                   http://www.debian.org/

> Index: debian/panic-action
> ===================================================================
> --- debian/panic-action (Revision 1139)
> +++ debian/panic-action (Arbeitskopie)
> @@ -18,11 +18,12 @@
> 
>         # Generic header for our email
>         echo "The Samba 'panic action' script, $0,"
> -       echo "was called for pid $1 ($BINARYNAME)."
> +       echo "was called for PID $1 ($BINARYNAME)."
>         echo
> 
> +       echo "This means there was a problem with the program, such as a 
> segfault."
> +
>         if [ -z "$BINARYNAME" ]; then
> -               echo "This means there was a problem with the program, such 
> as a segfault."
>                 echo "However, the executable could not be found for process 
> $1."
>                 echo "It may have died unexpectedly, or you may not have 
> permission to"
>                 echo "debug the process."
> @@ -31,7 +32,6 @@
> 
>         # No debugger
>         if [ ! -x /usr/bin/gdb ]; then
> -               echo "This means there was a problem with the program, such 
> as a segfault."
>                 echo "However, gdb was not found on your system, so the error 
> could not be"
>                 echo "debugged.  Please install the gdb package so that 
> debugging information is"
>                 echo "available the next time such a problem occurs."
> @@ -48,4 +48,4 @@
>         echo "http://www.debian.org/Bugs/Reporting or the reportbug(1) 
> manpage."
>         echo
>         gdb -x /etc/samba/gdbcommands -batch "$BINARYNAME" "$1"
> -) | mail -s "Segfault in Samba" root
> +) | mail -s "Problem in Samba" root
> 
> 

Attachment: signature.asc
Description: Digital signature

Reply via email to