Package: vserver-debiantools
Version: 0.3.0
Severity: minor

Hi Ola,

I noticed that in 0.3.0 you changed the pattern for validating
hostnames from:
   [a-z0-9]*([a-z0-9_-])[a-z0-9]
to:
   [a-z0-9]*[a-z0-9_-][a-z0-9]

That is wrong, because the former uses bash construction *() which
means zero or more occurences of characters inside the parenthesis,
while the latter * says any number of arbitrary characters, which
would allow hostmanes like a;'^%bc.

The *() construction is only available in bash after setting
shopt -s extglob, but it is set at the begining of the scripts, so why
not use it.

Next, I did mistake too, because the underscore is not valid in the
hostname, so please change the pattern to:

   [a-z0-9]*([a-z0-9-])[a-z0-9]

-- 
Miroslav Kure


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to