Jörg Sommer wrote: > Neil Williams schrieb am Mon 14. Aug, 14:38 (+0100): >> Jörg Sommer wrote: >>> Hello Neil, >>>> 2. -Wextra is *not supported* by gnucash and errors are to be expected. >>>> Don't use it. >>> -Wextra does not generate any errors. It warns about common cases where >>> errors can araise. >> -Wextra DOES generate errors under -Werror > > Who enabled -Werror?
Upstream - sometime during the gnome2 transition. >> I'd also recommend broaching this directly with gnucash upstream over >> IRC or the gnucash-devel mailing list. > > I will do that. Thanks - let me know how you get on. > Thanks for telling me your thoughts about this issue. Close this bugs as > you like. It's OK to leave for now. >> -Wextra is fine, IMHO, for small utilities and small libraries, like >> libqof1. Having reviewed it in that situation, I would not be willing to >> recommend adopting it for a large app like gnucash. YMMV. > > I think tons of lines of code are not an excuse to lower code quality and > ignore minor issues. But these are two opinions of two different people. I agree it's not excuse for lower code quality - I disagree that -Wextra is a *reliable* indicator, especially when it concerns applications that use a lot of function prototypes where one or more arguments may often be unused. Not using a provided variable is *not* an indicator of lower code quality. One final comment: Check out the use of a more specific combination of -W options that highlight the real issues as compared to the pointless warnings. In particular, look at -Wsign-compare with -Wconversion *without* using -Wunused. -- Neil Williams ============= http://www.data-freedom.org/ http://www.nosoftwarepatents.com/ http://www.linux.codehelp.co.uk/
signature.asc
Description: OpenPGP digital signature
