Hi,
I don't like this patch. It would mean that a assignment to a
constant (which can be optimized away) is being replaced by a
function call -- with all that entails (context switches, branch
misses), etc.
I would much rather do:
#include <asm/page.h>
#ifndef PAGE_SIZE
# define PAGE_SIZE getpagesize()
#endif
and only have the function call penalty hit powerpc
machines. It also minimizes the diff from upstream to three lines,
which is better :)
manoj
--
The universe does not have laws -- it has habits, and habits can be
broken.
Manoj Srivastava <[EMAIL PROTECTED]> <http://www.datasync.com/%7Esrivasta/>
1024D/BF24424C print 4966 F272 D093 B493 410B 924B 21BA DABB BF24 424C
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
