On Sun, Jul 23, 2006 at 01:36:46PM +0200, Thomas Schwinge wrote:
> Hello!

Hi!  Thanks for the patch.

> diff -ru pciutils-2.2.1.orig/lib/Makefile pciutils-2.2.1/lib/Makefile
> --- pciutils-2.2.1.orig/lib/Makefile  2004-08-13 22:29:06.000000000 +0200
> +++ pciutils-2.2.1/lib/Makefile       2006-01-20 01:53:05.000000000 +0100
> @@ -45,6 +45,10 @@
>  PCILIB=libpciutils.a
>  endif
>  
> +ifdef PCI_OS_GNU
> +CFLAGS += -D_GNU_SOURCE
> +endif

Do you need to touch the Makefile?  Would it be enough to instead do ...

> +++ pciutils-2.2.1/lib/i386-io-hurd.h 2006-01-20 02:08:58.000000000 +0100
>  
>  #include <sys/io.h>

+#define _GNU_SOURCE

instead?



I'm also a little concerned that you guys are still using the ioport
routines.  This config space access method doesn't support PCI domains
and doesn't support extended config space.  I hope someone's working on
some mechanism for Hurd to access MMCONFIG (for example) regions.



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to