On Tuesday 18 July 2006 18:12, Bas Wijnen wrote:
> There was a Debian bug reported about pioneers not building with non-bash
> shells (in particular dash).
>...
> Now I found another bashism, and there's not much we can do about it.  The
> problem is in /usr/bin/gnome-autogen.sh, from gnome-common.  The problem is
> that it uses a variable which may not be defined.  Actually it looks like
> they don't mean to use it anyway (it's about AUTOMAKE_VERSION, while they
> only use REQUIRED_AUTOMAKE_VERSION elsewhere).
>
> Now, the simplest way to go would be to file a bug against gnome-common
> (which I will do) and wait for it to be fixed.

If you include a patch, I think it can be much faster :-)

I've tested, if you replace AUTOMAKE_VERSION by REQUIRED_AUTOMAKE_VERSION in 
gnome-autogen.sh, the problem is solved.

> However, given that I still 
> didn't get a response to my previous bug report to them (#318424, a year
> ago), I'm afraid the "waiting" part will take too long.

BTW: Reading the 2.12 version of gnome-autogen.sh, I think the bug you filed 
was actually fixed, but not closed in the BTS.

> So we can implement a workaround, which is pretty easy (if the variable is
> defined, there is no problem).  It just results in some "junk" in
> debian/rules (only a single line, really).

Please don't try to fix it in debian/rules, but instead in  
macros/gnome-autogen.sh, and reassign this bug to gnome-common. The bug 
regarding Pioneers is not Debian specific.

See the attached patch against the current version of Pioneers.
If gnome-common is excluded from the required packages in Debian, the included 
version will be used, instead of the version from gnome-common.

Regards,
Roland Clobus
Developer for Pioneers
Index: gnome-autogen.sh
===================================================================
--- gnome-autogen.sh	(revision 1097)
+++ gnome-autogen.sh	(working copy)
@@ -151,7 +151,7 @@
     # but it contains only Automake's own macros, so we can ignore it.
 
     # Read the dirlist file, supported by Automake >= 1.7.
-    if compare_versions 1.7 $AUTOMAKE_VERSION && [ -s $cm_macrodirs/dirlist ]; then
+    if compare_versions 1.7 $REQUIRED_AUTOMAKE_VERSION && [ -s $cm_macrodirs/dirlist ]; then
 	cm_dirlist=`sed 's/[ 	]*#.*//;/^$/d' $cm_macrodirs/dirlist`
 	if [ -n "$cm_dirlist" ] ; then
 	    for cm_dir in $cm_dirlist; do

Attachment: pgpohxiXhpEOF.pgp
Description: PGP signature

Reply via email to