Hi, On Mon, Jul 10, 2006, Ian Wienand wrote: > Attached is a diff of the NMU for teatime 2.6
I have many problems with your NMU. 1) you sent the diff to a bug, but you should open a new bug when proposing a maintainer to merge the diff of one of your NMUs 2) as Sébastien pointed out, your NMU mostly addresses a new upstream release, this is not covered by NMU policy 3) your version number is incorrect, a NMU with a new upstream release should carry a Debian revision in -0.1, not -1.1 4) you did not upload your NMU immediately, nor did you say when you would upload it, and because of 3), this could have lead to rejected uploads > + * New upstream (Closes: #296874, #342518, #293595, #313902, #260517) 5) as Sébastien already pointed out, this is bad-style > + * Remove old patches no longer required 6) a list of patches considered "old" would have been useful, especially since you decided to keep parts of the libexec fix, but forgot to keep the relibtoolizing patch > + * Add patches/no-libexec.patch; unfortunately requires regenerating > Makefiles > + which leads to a big diff 7) this was done in the 04_libtoolized patch, but you decided to relibtoolize in the Debian diff instead; this is a change in packaging style which isn't innocent at all 8) your patch doesn't carry a number, how am I supposed to name a patch that I need to put higher or lower in the stack than yours? bad-style again > + * Update homepage in control, copyright This is ok, even if you kept the previous mistake of mentionning the tarball in copyright, I won't blame this on you. > -Build-Depends: cdbs, debhelper (>= 4.1), gnome-pkg-tools, libgtk2.0-dev, > libgnomeui-dev (>= 2.2), libpanel-applet2-dev, libgstreamer0.8-dev (>= > 0.8.1-2), libgstreamer-gconf0.8-dev (>= 0.8.1-2), libxml2-dev, libxml-perl > +Build-Depends: , cdbs (>= 0.4.23-1.1), autotools-dev, debhelper (>= 4.2.0), > patchutils (>= 0.2.25), debhelper (>= 4.2.21), automake1.9, autoconf, > debhelper (>= 4.1), gnome-pkg-tools, libgtk2.0-dev, libgnomeui-dev (>= 2.2), > libpanel-applet2-dev, libgstreamer0.8-dev (>= 0.8.1-2), > libgstreamer-gconf0.8-dev (>= 0.8.1-2), libxml2-dev, libxml-perl 9) the build-deps list is significantly longer but I can't find any reference to that in the changelog > -Standards-Version: 3.6.1 > +Standards-Version: 3.7.2 10) I suppose you can imagine why I'm not too happy about this either > +# see patches/no-libexecdir.patch > +DEB_AUTO_UPDATE_AUTOMAKE := 1.9 > +DEB_AUTO_UPDATE_AUTOCONF := 2.50 > + > + > +DEB_CONFIGURE_EXTRA_FLAGS := --libexecdir=/usr/lib/teatime/ > + This is part of your changes, so I will not comment again on these. > clean:: > + #workaround for gnome uploaders; see > + #http://perso.duckcorp.org/duck/cdbs-doc/cdbs-doc.xhtml > + sed -i "s/@cdbs@/$(CDBS_BUILD_DEPENDS)/g" debian/control > rm -f GNOME_TeatimeApplet_Factory.server 11) yet another thing I discover in the diff, which is a result of your personal taste for CDBS build-deps generation Your NMU has far too many problems, and is frankly awful. It also failed building everywhere but on your computer: <http://buildd.debian.org/build.php?arch=&pkg=teatime> You need to be stricter in your packaging style and practices, and even more for NMUs. -- Loïc Minier <[EMAIL PROTECTED]>
