Hi, this patch looks promising and would like to see it included.
However, some improvements could be made. One is that no variable stuff should
be hardcoded:
The "# Work out resource ranges, so we know which serial port to work with"
part should be done with setserial, too:
PORT=`grep io $x/resources | sed -e 's/io \(.*\)-.*/\1/'`
PORT=`for i in \`ls -1 /dev/ttyS* 2>/dev/null\`; do setserial $i; done |\
grep \`printf '0x%04x' $PORT\` | cut -f 1 -d ','`
One thing, though:
This should not (only) be done at startup but at installation time in the
debhelper framework. The reasons are simple:
- it is highly unlikely that such PnP-Ports change often enough
- the detection it yet another thing that (even if only slightly) increases
boot time
The recovery should be done using:
UART=`setserial -G $PORT`
and
setserial $UART
as there might be other option set that your script does not take care of. And
setserial makes it easy.
Additionally, since setserial is now used, irda-utils must depend on setserial
(and not only suggest it).
HS
pgpWEkr7uWOEs.pgp
Description: PGP signature
