Hi,

28 juil. 2026 20:56:34 Christopher Obbard <[email protected]>:
On Sun, 26 Jul 2026 at 18:55, Nicolas Peugnet <[email protected]> wrote:
On 26/07/2026 16:32, Nicolas Peugnet wrote:
I will properly finish the packaging of these tools and will ask you
soon for sponsorship :)

Here are the first three packages that are ready for review and upload: - https://salsa.debian.org/go-team/packages/golang-github-s-urbaniak-uevent
- https://salsa.debian.org/go-team/packages/arduino-mdns-discovery
- https://salsa.debian.org/go-team/packages/arduino-serial-monitor

I looked at all of these; they seem fine but you may want to squash
your packaging commits and upload the source packages to
mentors.debian.net. I can then upload them sponsoring you correctly.
Let me know when you've fixed the packaging repo && uploaded to
mentors and I will sponsor the uploads.

I would prefer not to squash them if it is ok with you.
I'm currently AFK but I can push them to mentors.d.n tomorrow.


The two other are not ready yet.
- https://salsa.debian.org/go-team/packages/arduino-dfu-discovery
- https://salsa.debian.org/go-team/packages/arduino-serial-discovery

The first one downloads some source files from dfu-util during build,
but as it is not a library I had to include them in the package. I
currently created a [patch] for this but I'm not a big fan of this
solution, so I created an [issue] upstream. I'm curious of your opinion.

[patch]:

https://salsa.debian.org/go-team/packages/arduino-dfu-discovery/-/blob/481a17080a7b3f597b80283d132dbf237e0a0006/debian/patches/0001-Add-missing-c-source-and-header-files-from-dfu-utils.patch
[issue]: https://github.com/arduino/dfu-discovery/issues/40

PS: My previous comments about squashing the packaging commits &&
uploading to mentors still apply.
I think this is fine; you may want to propose a bug report and
follow-up patch to the dfu-util package to ship headers/source; or if
possible just comment all of that tut out of arduino-dfu-discovery?

About getting the sources from the dfu-util package, I'm not sure that this is a good solution. The current version is compatible, but as it is not a library, there is no guarantee of compatibility whatsoever for the internal code. This looks more like a fork of dfu-util than a library usage, which is why the ideal solution IMO would be that upstream copies the files they need from dfu-util in their repo.

What you have is essentially vendoring dfu-util into the go package
which is.... quite a bit meh.

I agree 😓


The second one depends on golang-github-s-urbaniak-uevent and updated
golang-github-bugst-go-serial (for which I asked Simon for a sponsor
upload).

PS: My previous comments about squashing the packaging commits &&
uploading to mentors still apply.
I am happy to upload those if you want.

Simon uploaded bugst/go-serial so I will upload it to mentors at the same time as the first three.

--
Nicolas Peugnet

Attachment: signature.asc
Description: PGP signature

Reply via email to