Package: git-debpush
Version: 16.1~exp1
gregor herrmann writes ("Bug#1106071: closed by Debian FTP Masters
<[email protected]> (reply to Ian Jackson
<[email protected]>) (Bug#1106071: fixed in dgit 16.1~exp1)"):
> I just made my first upload of a -1 package with git-debpush 16.1~exp1
> with the pristine-tar support. [0]
Hi. I suppose I should have guessed that someone would see the BTS
traffic and try it out :-). There are still some minor rough edges to
sort out before a public announcement (which I'll make on d-d-a),
notably the large number of harmless warnigns in the email report.
> - I didn't know (or find out by reading the manpage) if I need to do
> anything or if the pristine-tar branch is just used when it's there
> or something else. In the end I just typed `git debpush' and read in
> the mailed log, that pristine-tar was used. Yay.
> A bit of explanation in the manpage might be nice.
Yes, it's basically magical. If your local pristine-tar branch has
data for the version you're uploading, it is used. There are
downstream checks that would detect and prevent usage of tarballs that
don't match your HEAD, so this is not as risky as it sounds.
I agree some of this should be documented. It would fit into
git-debpush(1) I think. The docs ought also to state what the inputs
are. In particular, it is a (soft) principle of git-debpush that it
only uses locally available information to generate the tag. Remote
information is only used to check that you're not making a mistake.
So probably there should be a "what does this command do" section.
> - There's one part in the POD which might need an update: the
> "pristine-tar" item in the --force documentation:
>
> https://salsa.debian.org/dgit-team/dgit/-/blob/experimental/git-debpush.1.pod?ref_type=heads#L317
Ah yes.
> (Side note, as I was `locate'ing through my disk: I have 5 local
> repos which have a .git/git-debpush/ direcory. Not sure what this is
> (maybe aborted uploads?) but if I had more than 5 of them on my disk
> I might be unhappy :))
These are harmless. got-debpush prefers using that for temporary
working areas, rather than /tmp. /tmp is very bad for lots of
reasons. If things succeed, it will normally delete it again. On
failure, it's deliberately left behind for diangosis.
This should be documented in FILES in git-debpush(1).
Ian.
--
Ian Jackson <[email protected]> These opinions are my own.
Pronouns: they/he. If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.
