Xiyue Deng <[email protected]> writes: > Hi Sean, > > Sean Whitton <[email protected]> writes: > >> Hello, >> >> If David would like to review and merge this I won't object. At the >> present time however I'm sceptical as to whether integration tests of >> this form will help us all that much with dh_elpa bugs. > > Please allow me to try to show the usefulness of the tests using the > filtering change as an example. With the proposed integration tests, we > can be sure that the change that removes the built-in addon filtering is > actually working by looking at the diff of the output files that the > built-in addons are showing up in generated files after the change, e.g. > "elpa-cl-lib (>= 0.1)". And it also helps us notice potential > regressions caused by future changes if we see them getting removed > accidentally.
As something more concrete: this commit[1] shows the diff after dh-elpa 2.2.0 release, and you can be sure that dh-elpa stops filtering built-in addon info correctly. [1] https://salsa.debian.org/emacsen-team/dh-elpa/-/commit/2fd65da7adc51e6baba14b507380a6dc096b4f53 -- Regards, Xiyue Deng
signature.asc
Description: PGP signature
