The Debian NEW review of ns3 3.48-1 has been completed. Decision: ACCEPTED Reviewer: Andrew McMillan
Review comment: Hi, Please review the list of authors found in source code review which are not acknowledged in the debian/copyright, but also when reviewing the debian/copyright please consider converting to DEP-5 format. Below, I have included a conversion to DEP-5 from your existing debian/copyright to use as a starting point. Please be aware that I may have made errors in this conversion, so your review is essential (and also then the addition of the authors that perhaps should also be acknowledged). Thanks! ================================================== Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: NS-3 Upstream-Contact: NS-3 Developers Source: http://www.nsnam.org/releases/ Files: * Copyright: Kirill Andreev <[email protected]> Nicola Baldo <[email protected]> Mirko Banchi <[email protected]> Ramon Bauza <[email protected]> Mehdi Benamor <[email protected]> Raj Bhattacharjea <[email protected]> Timo Bingmann <[email protected]> Pavel Boyko <[email protected]> Jonathan Brugge <[email protected]> Elena Buchatskaia <[email protected]> Gustavo Carneiro <[email protected]>, <[email protected]> Angelos Chatzipapas <[email protected]> Luis Cortes <[email protected]> Craig Dowell <[email protected]> David Gross <[email protected]> Mohamed Amine Ismail <[email protected]>, <[email protected]> Tom Henderson <[email protected]> Sam Jansen <[email protected]> Liu Jian <[email protected]> Joe Kopena <[email protected]> Aleksey Kovalenko <[email protected]> Mathieu Lacage <[email protected]> Emmanuelle Laprise <[email protected]> Keith Ma <[email protected]> Federico Maguolo <[email protected]> Antti Makela <[email protected]> Francesco Malandrino <[email protected]> Fabian Mauchle <[email protected]> Andrey Mazo <[email protected]> Faker Moatamri <[email protected]> Michael Nowatkowski <[email protected]> Duy Nguyen <[email protected]> Tommaso Pecorella <[email protected]> Yana Podkosova <[email protected]> Guangyu Pei <[email protected]> George F. Riley <[email protected]> Providence Salumu Munga <[email protected]>, <[email protected]> Guillaume Seguin <[email protected]> Kulin Shah <[email protected]> Phillip Sitbon <[email protected]> Ewgenij Starostin <[email protected]> Adrian S. W. Tam <[email protected]> Wilson Thong <[email protected]> Mauro Tortonesi <[email protected]> Andras Varga <[email protected]> Sebastien Vincent <[email protected]> Guillaume Vu-Brugier <[email protected]> Tom Wambold <[email protected]> Florian Westphal <[email protected]> Josh Pelkey <[email protected]> Thomas Nagy and others License: GPL-2 Files: nsc-*/* Copyright: Sam Jansen <[email protected]> WAND Network Research Group, Department of Computer Science, University of Waikato, Hamilton, New Zealand Florian Westphal And Others License: GPL-2 Files: nsc-*/linux-2.6*/* Copyright: Linus Torvalds and others License: GPL-2 Files: nsc-*/freebsd5/* Copyright: FreeBSD team and others License: BSD-3-Clause-FreeBSD Files: nsc-*/lwip-*/* Copyright: 2001, 2002 Swedish Institute of Computer Science. Adam Dunkels <[email protected]> License: BSD-3-Clause-lwIP Files: nsc-*/openbsd3/* Copyright: 1982, 1986, 1990, 1991, 1993 The Regents of the University of California. License: BSD-4-Clause Files: pybindgen-0.*/* Copyright: Gustavo J. A. M. Carneiro <[email protected]> <[email protected]> License: LGPL-2.1 Files: pybindgen-0.*/pybindgen/typehandlers/ctypeparser/tokenizer.py Copyright: 2007 Neal Norwitz 2007 Google Inc. License: Apache-2.0 Files: scons* Copyright: 2001-2008 The SCons Foundation License: Expat Files: bindings/python/rad_util.py Copyright: 2007 RADLogic License: Expat Files: bindings/python/topsort.py Copyright: 2007 RADLogic License: LGPL-2.1 Files: examples/flowmon/wif-olsr-flowmon.py Copyright: 2009 INESC Porto License: GPL-2 Files: examples/ipv6/test-ipv6.cc Copyright: 2008 Louis Pasteur University/Telecom Bretagne License: GPL-2 Files: examples/ipv6/radvd-two-prefix.cc examples/ipv6/radvd.cc examples/ipv6/loose-routing-ipv6.cc examples/ipv6/icmpv6-redirect.cc Copyright: 2009 Strasbourg University License: GPL-2 Files: examples/ipv6/ping6.cc examples/ipv6/fragmentation.cc Copyright: 2008-2009 Strasbourg University License: GPL-2 Files: examples/mesh/mesh.cc Copyright: 2008, 2009 IITP RAS License: GPL-2 Files: examples/routing/aodv.cc Copyright: 2009 IITP RAS License: GPL-2 Files: examples/routing/nms_p2p_nix.cc Copyright: 2009 GTech Systems, Inc. - Alfred Park <[email protected]> License: GPL-2 Files: examples/routing/simple-routing-ping6.cc examples/routing/simple-routing-ping6.py Copyright: 2008-2009 Strasbourg University License: GPL-2 Files: examples/stats/* Copyright: Joe Kopena <[email protected]> License: GPL-2 Files: examples/tunneling/virtual-net-device.cc Copyright: 1996 Steve McCanne License: GPL-2 Files: examples/wireless/wifi-ap.py Copyright: 2005-2007 INRIA 2009 INESC Porto Mathieu Lacage <[email protected]> Gustavo Carneiro <[email protected]> License: GPL-2 Files: examples/wireless/wifi-clear-channel-cmu.cc Copyright: 2009 The Boeing Company Guangyu Pei <[email protected]> License: GPL-2 Files: examples/wireless/wifi-simple-adhoc.cc examples/wireless/wifi-simple-infra examples/wireless/wifi-simple-interference.cc Copyright: 2009 The Boeing Company License: GPL-2 Files: examples/wireless/wifi-simple-adhoc-grid.cc Copyright: 2009 University of Washington License: GPL-2 Files: examples/wireless/wifi-ap.cc examples/wireless/wifi-adhoc.cc Copyright: 2005-2007 INRIA Mathieu Lacage <[email protected]> License: GPL-2 Files: examples/wireless/simple-wifi-frame-aggregation.cc Copyright: 2009 MIRKO BANCHI Mirko Banchi <[email protected]> License: GPL-2 Files: examples/wireless/multirate.cc Copyright: Duy Nguyen <[email protected]> License: GPL-2 Files: samples/main-attribute-value.cc Copyright: 2008 University of Washington Tom Henderson <[email protected]> License: GPL-2 Files: samples/main-packet-tag.cc Copyright: 2006, 2007 INRIA Mathieu Lacage <[email protected]> License: GPL-2 Files: samples/main-propagation-loss.cc samples/main-random-variable.cc Copyright: 2008 Timo Bingmann Timo Bingmann <[email protected]> License: GPL-2 Files: samples/main-tw.cc Copyright: 2007 University of Washington License: GPL-2 Files: utils/bench-packets.cc utils/bench-simulator Copyright: 2006 INRIA Mathieu Lacage <[email protected]> License: GPL-2 Files: utils/test-runner.cc Copyright: 2009 University of Washington License: GPL-2 Files: utils/Iconv/genhtml utils/geninfo utils/Iconv/* Copyright: 2002 International Business Machines Corp. 2002-2004 Peter Oberparleiter <[email protected]> 2002 Manoj Iyer <[email protected]> 2002 Megan Bock <[email protected]> 2002 Mike Kobler 2003-2004 Laurent Deniel 2003 Nigel Hinds 2003 Paul Larson 2004 Andreas Krebbel License: GPL-2+ Files: waf-tools/pkg_config.py Copyright: 2008 Gustavo Carneiro (gjamc) License: GPL-2 Files: waf-tools/shellcmd.py Copyright: 2008 Gustavo J. A. M. Carneiro <[email protected]> License: GPL-2+ Files: debian/waf-*/* Copyright: 2008 Thomas Nagy and others License: BSD-3-Clause-WAF Files: debian/* Copyright: 2010 YunQiang Su <[email protected]> License: GPL-2 License: GPL-2 This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License. . On Debian systems, the full text of the GNU General Public License version 2 can be found in the file `/usr/share/common-licenses/GPL-2`. License: GPL-2+ This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. . On Debian systems, the full text of the GNU General Public License version 2 can be found in the file `/usr/share/common-licenses/GPL-2`. License: LGPL-2.1 This program is free software; you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License. . On Debian systems, the full text of the GNU Lesser General Public License version 2.1 can be found in the file `/usr/share/common-licenses/LGPL-2`. License: Apache-2.0 Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at . http://www.apache.org/licenses/LICENSE-2.0 . Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. . On Debian systems, the full text of the Apache License version 2.0 can be found in the file `/usr/share/common-licenses/Apache-2.0`. License: Expat Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: . The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. . THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. License: BSD-3-Clause-FreeBSD Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: 1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. 2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. 3. Neither the name of the copyright holder nor the names of contributors may be used to endorse or promote products derived from this software without specific prior written permission. . THIS SOFTWARE IS PROVIDED BY THE PROJECT AND CONTRIBUTORS ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE PROJECT OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. License: BSD-3-Clause-lwIP Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: . 1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. 2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. 3. The name of the author may not be used to endorse or promote products derived from this software without specific prior written permission. . THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. License: BSD-3-Clause-WAF Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: . 1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. . 2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. . 3. The name of the author may not be used to endorse or promote products derived from this software without specific prior written permission. . THIS SOFTWARE IS PROVIDED BY THE AUTHOR "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT,INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. License: BSD-4-Clause Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: 1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. 2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. 3. All advertising materials mentioning features or use of this software must display the following acknowledgement: This product includes software developed by the University of California, Berkeley and its contributors. 4. Neither the name of the University nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission. . THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. ================================================== Full review details: https://dfsg-new-queue.debian.org/reviews/ns3
