Hi Sean, Sean Whitton <[email protected]> writes:
> Xiyue Deng [10/Jun 11:23pm -07] wrote: >> So I guess this can really work! > > Nice. > >> Will continue with this after the integration test is merged so that >> we have some test coverage. > > IMO this is more important than that other work and can merge first. Ah I was hoping that the test branch is safer as it doesn't change any functions and can go in first. Anyway, I experimented a change[1] and tested it in the `built-in-addon-handling' branch, and rebased it on to the test branch for testing. One of the test cases has cl-lib in Package-Requires, and the generated diff looked OK[2]. So now we only remove `emacs' from the list of dependencies. The code can be further simplified, but I'd like to keep the current structure in case we want to do more later. Thanks! [1] https://salsa.debian.org/emacsen-team/dh-elpa/-/commit/7eb8779e4a76392d04fd1fee4ac1936cdfd8a9d7 [2] https://salsa.debian.org/emacsen-team/dh-elpa/-/commit/5c6df966e53069b8e0ade0697fddef0a1cbafdc7 -- Regards, Xiyue Deng
