On Fri, Jun 05, 2026 at 08:39:40PM +0100, Mark Hindley wrote:
I notice you have provided ucf-helper-functions.sh. The only file currently in
/usr/share/ucf is ucf_library.sh (note underscore). Would you be happy with
ucf_helper_functions.sh for consistency?
Absolutely. No problem. I did a git rename in my branch, is that okay
for you or would you rather have me rewrite history, having all commits
with the underscored file name in the first place?
In rename_ucf_file(), using sed to modify /var/lib/ucf/hashfile is not ideal. I
accept that there used to be no documented way of doing this. But see
examples/README.md. I wonder if a better solution is to use something like
ucf "${oldname}" "{$newname}"
ucf --purge "${oldname}"
That doesn't look right to me. First, after the change, the testsuite
fails. I didn't investigate further.
Second, this would result in
# added
ucf "${oldname}" "{$newname}"
ucf --purge "${oldname}"
# already there
ucfr --purge "${PKGNAME}" "${oldname}"
ucfr "${PKGNAME}" "${newname}"
That looks to me like the hashfile poking is necessary and the two ucfr
calls that were already there fix some fallout. And, being an official
part of the ucf package proper, ucf_helper_functions.sh should be
allowed to access ucf internal interfaces.
I'd prefer to keep the code as is. If that's a rejection reason for you,
I'll take a closer look at why the testsuite fails.
Greetings
Marc
--
-----------------------------------------------------------------------------
Marc Haber | "I don't trust Computers. They | Mailadresse im Header
Leimen, Germany | lose things." Winona Ryder | Fon: *49 6224 1600402
Nordisch by Nature | How to make an American Quilt | Fax: *49 6224 1600421
