On Mon, Jul 03, 2006 at 09:07:59PM +0100, Adrian Bridgett wrote: > I've ported a patch which adds SHA512 support to mod-auth-mysql to the > latest version in sarge. This is useful for integration into jira, > confluence and other programs using sha512.#
Thanks for making the patch. A few comments, though: > -#define AUTH_MYSQL_VERSION "4.3.9" > +#define AUTH_MYSQL_VERSION "4.3.9-2" Style note: I know this version number won't end up in the Debian package anyway, but it's better not to number your private versions with dashes because it conflicts with the Debian version numbering. I usually use 'mpalmer1' or '.1' (or '.2' in your case) instead. > +#ifdef _SHA512 > +/* > + * SHA-512 code by Jean-Luc Cooke <[EMAIL PROTECTED]> > + * > + * Copyright (c) Jean-Luc Cooke <[EMAIL PROTECTED]> > + * Copyright (c) Andrew McDonald <[EMAIL PROTECTED]> > + * Copyright (c) 2003 Kyle McMartin <[EMAIL PROTECTED]> > + */ Oh nononono. Crypto code goes somewhere *other* than mod_auth_mysql.c -- a separate file is good. A separate package is even better (I can't believe that there's no library in Debian that provides SHA512 hashing). More importantly, though, there's no licence statement with this code. It's non-distributable. A patch for the documentation would also be appreciated. - Matt -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
