Hello Santiago,
Am 28.03.26 um 14:54 schrieb Santiago Vila:
Hi.
I tried my script "check-nocheck" on this package, and this was the outcome:
==== Checking annotations for package python-selectolax ====
Trying with all build-dependencies
Build worked
Trying without liblexbor-dev
Build did NOT work, liblexbor-dev should not have <!nocheck>
Trying without libmodest-dev
Build did NOT work, libmodest-dev should not have <!nocheck>
Trying without python3-pytest
Build worked, it is ok to keep python3-pytest <!nocheck>
Trying without python3-pytest-cov
Build worked, it is ok to keep python3-pytest-cov <!nocheck>
Trying without python3-pytest-cython
Build worked, it is ok to keep python3-pytest-cython <!nocheck>
==== build-dependencies that should drop their <!nocheck> annotation ====
liblexbor-dev
libmodest-dev
You can find my script here, it's linked from the wiki page referenced
in the bug report:
https://people.debian.org/~sanvila/check-nocheck/
Based on the above, the attached patch should fix the bug.
I leave the upload to you (unless you prefer that I do it,
if so, just ask).
yes, the suggested patching solves the issue.
And now I know also why I was on the wrong way, I had a twist in my
brain due the negative logic of the profile syntax (! nocheck == not
equal nocheck).
So yes, the two currently wrong tagged build dependencies are needed for
building the package, not for running the tests.
[ Note: While I recommend that you use "sbuild --profiles=nocheck"
to check this, you verified "by hand" that the package really needs
those two build-dependencies even when DEB_BUILD_OPTIONS=nocheck,
so I don't understand what else did you need. You say at the end that
you verified that the package built ok with nocheck build profile,
but this bug suggests that whatever you did to check that was not
working. If you tell me what you did, maybe we can figure out
what was the problem ].
I usually still preferable using pbuilder locally in combination with
git-buildpackage then together with using DEB_BUILD_OPTIONS while
calling to build something.
This is for me flexible enough to run various testing without doing too
much different steps.
I'll intend to upload a newer upstream version along with the correction
on the needed B-D packages the next days. I need to do some more and
other things first.
Thanks for clearing out the situation!
--
Regards
Carsten
