tags 374645 patch
thanks
Hello,
On Tue, Jun 20, 2006 at 07:13:24PM +0700, Anon Sricharoenchai wrote:
>
> In /usr/bin/dpkg-source,
> for $dircreate (keys %dirtocreate) {
> $dircreatem= "";
> for $dircreatep (split("/",$dirc)) { <-- $dirc should be $dircreate?
> $dircreatem.= $dircreatep;
> if (!lstat($dircreatem)) {
> $! == ENOENT || &syserr("cannot stat $dircreatem");
> mkdir($dircreatem,0777)
> || &syserr("failed to create $dircreatem subdirectory");
> }
> else {
> -d _ || &error("diff patches file in directory
> \`$dircreate',"
> ." but $dircreatem isn't a directory !");
> }
> }
> }
Yes, $dirc should be $dircreate
And we should also insert something like
$dircreatem.= "/" if (length $dircreatem);
before
$dircreatem.= $dircreatep;
In fact, I wonder if it would not be better to just remove this paragraph
(which does nothing at this time because of the above bug).
It is used to create the directories which do not exist in the original
tar ball, but are necessary for the files added by the diff.gz.
The version of dpkg in Sarge also has this bug (and patch safely creates
the directories, so this has no consequences).
Kind Regards,
--
Nekral
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
