Control: owner -1
Control: tags -1 moreinfo

Michael Lloyd:
Package: sponsorship-requests
Severity: normal

Dear mentors,

[...]

  uhubctl (2.6.0-3) unstable; urgency=medium
  .
    * New maintainer (Closes: #1114569).
    * d/control: Update Vcs fields.
    * d/copyright: Update for new maintainer and copyright years.
    * d/watch: Update watch file standard.
    * d/patches: Rename debian-changes to descriptive quilt patch.
    * Migrate from dgit-maint-merge to gbp workflow.
    * Add d/gbp.conf and d/salsa-ci.yml.
    * d/copyright: Fix old FSF address lintian warning.
    * Add d/clean for generated manpage.
    * d/copyright: Add Upstream-Contact field.

Regards,

Hi Michael

Thanks for your contribution.

I have added you to https://salsa.debian.org/debian/uhubctl, so you can (if you want) maintain the packaging there. If so, please revert the the Vcs header change. I am willing to sponsor the package either way, but it changes how I perform the upload and who creates the tag. If you have no strong preference, I recommend using `debian/uhubctl`.

Secondly, the `d/watch: Update watch file standard.` line in `d/changelog` seems incorrect now. As far as I can tell the `d/watch` file was replaced by add `Archive: GitHub` to `d/upstream/metadata` and `d/changelog` should ideally be updated to match.

Some minor things noted by `debputy lint`[1] that you may want to consider (for now or later):

 * `Name` and `Contact` in `debian/upstream/metadata` are deprecated
   and replaced by `Upstream-Name` and `Upstream-Contact` in
   `debian/copyright`. Since you already use those, you can just remove
   those fields from `debian/upstream/metadata`

   (`debputy lint` says unsuported rather than deprecated, which is a
   bug in `debputy`)

 * The `Depends: @` in `debian/tests/control` is redundant as it is
   set to the default value. The field can be removed with no loss
   in functionality.


In summary, please decide on the on the VCS and fix the `debian/changelog` and please follow up on the bug with me directly in CC/To. The `debputy lint` findings here are optional in my book. Thanks for looking at improving Debian.

Best regards,
Niels


[1]: Shameless plug as I am the author of said tool. Whether you use it is optional. If you are interested, the quick start is:

$ apt-get install debputy-lsp
$ cd source-root
$ debputy lint

Note: Ensure `dh-debputy` (pulled via `debputy-lsp`) is from `trixie-backports` or `unstable` if you want to use the tool. If you do use it, you may want to use its editor support mode (https://salsa.debian.org/debian/debputy/-/blob/main/GETTING-STARTED-WITH-LINT-AND-LSP-FEATURES.md?ref_type=heads#editor-assistance-lsp).

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to