Hi, I took python-bitcointx from irc DPT topic. I leave some comments:
- My only concern that use an old libsecp25b6k1
- d/control: Priority as optional may be optional
- d/copyright: Please review copyright holders. Following the current copyright
file i.e. the file bitcointx/core/key.py should have all holders you mentioned
in Files: *, but only Sam Rushing, The python-bitcoinlib developers, and
python-bitcointx developers are the copyright holders.
- LICENSE and setup.py mention that the license is LGPL-3+, but why do declare
all files as Expat?
Please let me know when you have new version to review.
--
cheers,
Emmanuel Arias
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ [email protected]
⢿⡄⠘⠷⠚⠋⠀ OpenPGP: 13796755BBC72BB8ABE2AEB5 FA9DEC5DE11C63F1
⠈⠳⣄
signature.asc
Description: PGP signature
