Bug#1121339: dh-debputy: manifest rules generating (Static-)Built-Using fields

[Niels Thykier]

Nicolas Boulenguez:

Package: dh-debputy
Followup-For: Bug #1121339

Happy new year.
Thanks for merging.
I have rebased and pushed some work that I was preparing to the
bug-1121339-built-using branch.

Thanks, I cherry-picked the commit, since there was a WIP commit prior

to the merge commit (bd250c063ce2b68d7a71c342550360c1ad035d1d). It looked sufficiently like the commit I already squashed into cf4b4ce36925c84339a78415822ac7c54e5e5209, so I assumed its presence was not intentional. Though if you disagree, please add the remaining delta on top of the mainline without `WIP` in the commit (I have a pre-push hook to avoid pushing `WIP` commits)

I also added a minor tweak to the migration code such that it
detects `dh-builtusing` patterns and emits a warning about having to
migrate the manually. Ideally, that migration would be automated but
the migration infrastructure does not support patching
`debian/control` yet, so that was a "better than nothing" fix.

It may be better that way.  Some (mostly deprecated) stuff in
dh-builtusing would be hard to translate automatically anyway.

Ok.

I tweaked the logging so it now uses the exact path to the pattern
in the manifest when logging (such as
`packages.NAME.built-using[0].sources`)

The hash key is 'sources-for', not 'sources'.  Moreover, I have used
the parent 'packages.NAME.built-using[0]' when the reported issue is
not caused by the glob.

Thanks. I had not noted the distinction of warning about the entire structure when it was not the pattern causing the issue. After cherry picking your fixes here, I only found one left over case of `sources` instead of `sources-for` from the migration code, so they should all be gone now.

I tweaked the tests to skip running the metadata detector when the
  package is not active. I am happy to accept patches or merge
  requests for additional tests to cover anything you might feel
  would be lost by this change.

No problem. I have completely removed these tests, which were copied
from dh-sequence-builtusing but make little sense here.

Thanks for the refactor and simplification there as well. :)


Once again, thanks for contributing to `debputy`. :)

Best regards,
Niels

OpenPGP_signature.asc
Description: OpenPGP digital signature