Source: infnoise
Version: 0.3.3+dfsg-1
Severity: important
Tags: patch

Dear maintainer,

infnoise supports both the old libfdi library (based on the deprecated
libusb 0.1 library) and the libftdi1 library (based on libusb 1.0).

Please switch to the newer libftdi1 library for the Debian package. It
requires changing the debian/rules file, as it overrides CFLAGS and
misses -I flag for the libftdi1 include directory, while it is present
in the upstream makefiles. I ended up with the following patch:


--- infnoise-0.3.3+dfsg/debian/control
+++ infnoise-0.3.3+dfsg/debian/control
@@ -4,7 +4,7 @@
 Maintainer: Stephen Kitt <[email protected]>
 Build-Depends:
  debhelper-compat (= 13),
- libftdi-dev,
+ libftdi1-dev,
 Standards-Version: 4.6.2
 Homepage: https://github.com/leetronics/infnoise
 Vcs-Browser: https://salsa.debian.org/debian/infnoise
--- infnoise-0.3.3+dfsg/debian/rules
+++ infnoise-0.3.3+dfsg/debian/rules
@@ -13,8 +13,8 @@
        dh_auto_clean -Dsoftware/tools
 
 override_dh_auto_build:
-       dh_auto_build --buildsystem=makefile -Dsoftware -- -f Makefile.linux 
CFLAGS="$(CPPFLAGS) $(CFLAGS) $(LDFLAGS) -fPIC -IKeccak 
-DGIT_VERSION=\\\"$(DEB_VERSION_UPSTREAM)\\\" -DGIT_COMMIT=\\\"Debian\\\" 
-DGIT_DATE=\\\"$(shell date --utc +%FT%T%:z -d @$(SOURCE_DATE_EPOCH))\\\" 
-DLINUX"
-       dh_auto_build -Dsoftware/tools -- CFLAGS="$(CPPFLAGS) $(CFLAGS) 
$(LDFLAGS)"
+       dh_auto_build --buildsystem=makefile -Dsoftware -- -f Makefile.linux 
CFLAGS="$(CPPFLAGS) $(CFLAGS) $(LDFLAGS) -fPIC -IKeccak -I/usr/include/libftdi1 
-DGIT_VERSION=\\\"$(DEB_VERSION_UPSTREAM)\\\" -DGIT_COMMIT=\\\"Debian\\\" 
-DGIT_DATE=\\\"$(shell date --utc +%FT%T%:z -d @$(SOURCE_DATE_EPOCH))\\\" 
-DLINUX "
+       dh_auto_build -Dsoftware/tools -- CFLAGS="$(CPPFLAGS) $(CFLAGS) 
$(LDFLAGS) -I /usr/include/libftdi1"
 
 override_dh_auto_configure:
 # Copy various files so that debhelper tools can process them


Thanks
Aurelien

Reply via email to