Package: git-debpush
Version: 13.20
Hi, Simon. We saw this failure. tl;dr: I think it's not your fault.
Debian tag2upload service writes ("[tag2upload 2255] failed, cppi 1.18-4"):
> url: https://salsa.debian.org/debian/cppi.git
...
> dgit (build host): error: dgit: --upstream-commitish only makes sense with
> --quilt=baredebian
Sure enough, the tag says:
[dgit distro=debian split --quilt=baredebian+tarball]
[dgit please-upload source=cppi version=1.18-4 upstream-tag=upstream/1.18
upstream=42505de52b878ff751f0edf54dc07314dea27ee7]
According to dgit(1), baredebian+tarball means this:
--quilt=baredebian+tarball is like --quilt=baredebian, but is
used when there is no appropriate upstream git history. To con‐
struct the dgit view, dgit will import your orig tarballs' con‐
tents into git. In this mode, dgit cannot check that the up‐
stream parts of your upload correspond to what you intend: dgit
relies on the right orig tarball(s) existing, and debian/patches
being correct.
By "your orig tarballs" it means the ones in your build-products-dir.
This obviously makes no sense with tag2upload and the service was
correct to reject it.
The information in the tag doesn't say, but I am almost certain that
Simon didn't specify baredebian+tarball explicitly. The previous
upload was done with dgit, and --quilt=baredebian+tarball.
https://browse.dgit.debian.org/cppi.git/tag/?h=archive/debian/1.18-3
So I think git-debpush just reused that quilt mode.
For an existing upstream version, the upload could theoretically have
succeeded if we could have told the service "there is an orig in the
archive, you mmust use that". I'm not sure our tag format has a way
of requesting this, but the service implementation doesn't: it
tries to obtain origs iff there is an upstream commitid in the tag.
For a new upstream version, this quilt mode cannot be supported,
because it would involve conveying a tarball from the user's system to
the service. (#1106071 is relevant, but I doubt we would want
git-debpush to *generate* pristine-tar data.)
Anyway, at the very least git-debpush ought to have stopped rather
than asking the service to do something nonsensical.
Ian.
--
Ian Jackson <[email protected]> These opinions are my own.
Pronouns: they/he. If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.
