X-Debbugs-Cc: [email protected]
Package: release.debian.org
Severity: normal
Tags: trixie
User: [email protected]
Usertags: pu

Hi,

please allow libguestfs/1:1.54.1.2+deb13u1 to be uploaded.

[ Reason ]

libguestfs/1:1.54.1.2 as shipped with trixie has dependencies set so
that either isc-dhcp-client or dhcpcd can be used to provide network
connectivity to the VM spawned by libguestfs. However, activating
networking only works if the host has the dhcpcd package installed.

Most notably, this affects utilities that need network access to install
packages, such as virt-builder, virt-install, and virt-customize, cf.
#1111785 or [1]

[ Impact ]

Users will need to install a seemingly unrelated package (dhcpcd) as a
workaround.

[ Tests ]

On my Debian/trixie-based workstation, the package shows no regressions.
A friend has confirmed that on a Proxmox VE 9 default installation,
virt-builder et al can now be used without the workaround mentioned
above.

[ Risks ]

I don't expect anything obvious to break.

[ Checklist ]

  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
  [?] the issue is verified as fixed in unstable

The upload of libguestfs/1:1.56.2-2 to unstable is sitting in NEW at the
moment, but it contains the same fix.

[ Changes ]

Package isc-dhcp-client is added to the build-dependencies. This causes
the package name to be added to the Supermin appliance's packagelist
(/usr/lib/<multiarch-triplet>/guestfs/supermin.d/packages) which is
shipped as part of the libguestfs0t64 binary package.

The build-dependency had previously been removed when switching to
dhcpcd (see #1106125, [2]).

The packagelist now contains both isc-dhcp-client and dhcpcd. Since
supermin cannot deal with alternative dependencies it will only add
files from those packages into the sppliance that can actually be found
on the host system. The init script[3] then figures out which DHCP
client to choose.

[ Other info ]

Users of downstream distributions (Proxmox VE 9, Ubuntu 24+) may also
find this update useful.

Cheers,
-Hilko

[1] https://github.com/libguestfs/libguestfs/issues/211.
[2] https://salsa.debian.org/libvirt-team/libguestfs/-/merge_requests/4
[3] https://sources.debian.org/src/libguestfs/1%3A1.54.1-2/appliance/init

diff -Nru libguestfs-1.54.1/debian/changelog libguestfs-1.54.1/debian/changelog
--- libguestfs-1.54.1/debian/changelog	2025-05-24 21:31:19.000000000 +0200
+++ libguestfs-1.54.1/debian/changelog	2025-12-31 14:47:21.000000000 +0100
@@ -1,3 +1,11 @@
+libguestfs (1:1.54.1-2+deb13u1) trixie; urgency=medium
+
+  * Create trixie-updates branch
+  * Add isc-dhcp-client dependency so it is added to the packagelist
+    (Closes: #1111785)
+
+ -- Hilko Bengen <[email protected]>  Wed, 31 Dec 2025 14:47:21 +0100
+
 libguestfs (1:1.54.1-2) unstable; urgency=medium
 
   * Replace isc-dhcp-client build-dependency with dhcpcd-base.
diff -Nru libguestfs-1.54.1/debian/control libguestfs-1.54.1/debian/control
--- libguestfs-1.54.1/debian/control	2025-05-22 11:42:34.000000000 +0200
+++ libguestfs-1.54.1/debian/control	2025-12-31 14:45:51.000000000 +0100
@@ -89,6 +89,7 @@
   iputils-arping,
   iputils-ping,
   iputils-tracepath,
+  isc-dhcp-client,
   jfsutils,
   kmod | module-init-tools,
   kpartx,
diff -Nru libguestfs-1.54.1/debian/gbp.conf libguestfs-1.54.1/debian/gbp.conf
--- libguestfs-1.54.1/debian/gbp.conf	2023-07-23 13:30:56.000000000 +0200
+++ libguestfs-1.54.1/debian/gbp.conf	2025-12-31 14:45:51.000000000 +0100
@@ -1,5 +1,5 @@
 [DEFAULT]
 upstream-branch = upstream
-debian-branch = debian
+debian-branch = debian/trixie-updates
 [pq]
 patch-numbers = false

Reply via email to