Package: git-debpush
Version: 13.20
Severity: important

git-deborig:

 1. Installs a new .git/info/attributes
 2. Does some stuff
 3. Deletes the .git/info/attributes or restores a preexisting one

This is not sound.  If it crashes during 2 (whether because it detects
errors, or maybe got a signal or something) the .git/info/attributes
file is left in place.

After that, the user's git tree may start to behave oddly.
Furthermore, currently, there isn't even any note left in
the .git/info/attributes to say what happened!

The corruption is only that gitattributes are defused when not
expected.  This will become worse if we make git-deborig defuse *all*
the attributes, not just export-*.

Looking at the git documentation, I think git-deborig needs to use a
playtree.

Ian.

-- 
Ian Jackson <[email protected]>   These opinions are my own.  

Pronouns: they/he.  If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.

Reply via email to