Hello,

cmake/FindFilesystem.cmake is now included. As for the leb128 files, is 
the "Apache-2.0 and BSD-3-clause" description inaccurate? As far as I 
can tell, those files have to comply with both licenses.

I don't think I can make a new upload with a fixed d/copyright since the 
package is still sitting in NEW, correct me if I'm wrong.

Thanks for taking a look!
--
Ben Westover

On 12/25/25 8:16 AM, Reinhard Tartler wrote:
> Hi,
> 
> I took a look at the dpp package as found in
> https://salsa.debian.org/debian/dpp and found a couple of issues that should 
> be
> addressed before accepting it into debian. See my notes below:
> 
> The file below is not mentioned in debian/copyright at all:
> 
> cmake/FindFilesystem.cmake
> 1:# Distributed under the OSI-approved BSD 3-Clause License.  See accompanying
> 2:# file Copyright.txt or https://cmake.org/licensing for details.
> 
> 
> Inaccurate description in debian/copyrigh, those files are apparently taken
> from
> https://webrtc.googlesource.com/src/+/refs/heads/main/modules/rtp_rtcp/source/leb128.cc
> and claimed as apache 2.0. That's not compliant with the BSD-3 license as
> outlined at https://webrtc.googlesource.com/src/+/refs/heads/main/LICENSE:
> 
> src/dpp/dave/leb128.h
> 5: * SPDX-License-Identifier: Apache-2.0
> 6: * Copyright 2021 Craig Edwards and D++ contributors
> 9: * Licensed under the Apache License, Version 2.0 (the "License");
> 10: * you may not use this file except in compliance with the License.
> 11: * You may obtain a copy of the License at
> 13: * http://www.apache.org/licenses/LICENSE-2.0
> 16: * distributed under the License is distributed on an "AS IS" BASIS,
> 18: * See the License for the specific language governing permissions and
> 19: * limitations under the License.
> 22: *  Copyright (c) 2023 The WebRTC project authors. All Rights Reserved.
> 24: *  Use of this source code is governed by a BSD-style license
> 25: *  that can be found in the LICENSE file in the root of the source
> 
> 
> src/dpp/dave/leb128.cpp
> 5: * SPDX-License-Identifier: Apache-2.0
> 6: * Copyright 2021 Craig Edwards and D++ contributors
> 9: * Licensed under the Apache License, Version 2.0 (the "License");
> 10: * you may not use this file except in compliance with the License.
> 11: * You may obtain a copy of the License at
> 13: * http://www.apache.org/licenses/LICENSE-2.0
> 16: * distributed under the License is distributed on an "AS IS" BASIS,
> 18: * See the License for the specific language governing permissions and
> 19: * limitations under the License.
> 22: *  Copyright (c) 2023 The WebRTC project authors. All Rights Reserved.
> 24: *  Use of this source code is governed by a BSD-style license
> 25: *  that can be found in the LICENSE file in the root of the source
> 
> 
> Let me know if you have further questions.

Attachment: OpenPGP_signature.asc
Description: PGP signature

Reply via email to