Control: tags 1123620 patch
stop
Hi Daniel,
Il 19/12/25 21:30, Daniel Echeverri ha scritto:
[...]
The patch you are referring to has already been merged upstream and is included
in the version currently packaged in Debian [1].
can you please carefully compare the code in [1] with the code resulting after
the patch [4]? In [1] the whole
if (ofv_append_varr(&pppd_args, "plugin")) {
[...]
}
block is missing. It was accidentally removed when removing support for the
deprecated '--plugin' option. The parent if {} block takes care to append to
the pppd command line:
- 1st if {}: the 'plugin' keyword (missing in original v1.24.0 code);
- 2nd if {}: the _not_deprecated_ openfortivpn '--pppd-plugin' option value.
As a result, the value of the '--pppd-plugin' openfortivpn option is passed
without the needed 'plugin' preceding keyword, and pppd errors out.
[...]
Also, it seems that there may be plans to eventually remove this package from
Debian [2][3].
The package hasn't been removed yet (and I hope it won't for the reasons I
explained in my original bug report).
This is nevertheless a bug, since openfortivpn doesn't correctly pass to pppd
the --pppd-plugin option value as per documentation, causing a connection failure.
[...]
[1]: https://salsa.debian.org/debian/openfortivpn/-/blob/master/src/tunnel.c?
ref_type=heads#L359 <https://salsa.debian.org/debian/openfortivpn/-/blob/
master/src/tunnel.c?ref_type=heads#L359>
[...]
Thanks
[4]: https://github.com/adrienverge/openfortivpn/pull/1325/files
