Package: dpkg
Version: 1.23.0
Severity: minor

I saw this in a CI log [1]:

  225s dpkg-source: warning: --auto-commit is not a valid option for 
Dpkg::Source::Package::V3::Native

I think it would be more sensible to treat --auto-commit as "auto
commit *if necessary*" (which is already what it does for "3.0 (quilt)")
and therefore say that for formats that don't need "committing",
it is a no-op.

So I don't think it makes sense to print a warning about it - passing
this option when it's not needed is normal.  A tool might reasonably
always pass --auto-commit without even caring what the source format
is.  We surely don't expect the authors of a script that calls
dpkg-source to inspect the source format to try to decide whether to
pass --auto-commit or not.

Thanks,
Ian.

[1] https://ci.debian.net/packages/l/lintian/testing/amd64/67253141/#L4872

-- 
Ian Jackson <[email protected]>   These opinions are my own.  

Pronouns: they/he.  If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.

Reply via email to