Package: scour
Version: 0.38.2-2
Severity: minor
Tags: patch

Dear Maintainer,

Some of the test cases in scour return booleans. Returning non-None values from
test cases was deprecated in https://github.com/pytest-dev/pytest/issues/7337 ,
so running these tests causes DeprecationWarning.

Attached is a patch that makes them return None.


-- System Information:
Debian Release: 12.12
  APT prefers oldstable-updates
  APT policy: (500, 'oldstable-updates'), (500, 'oldstable-security'), (500, 
'oldstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.1.0-41-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages scour depends on:
ii  python3        3.11.2-1+b1
ii  python3-scour  0.38.2-2

scour recommends no packages.

Versions of packages scour suggests:
ii  gir1.2-rsvg-2.0   2.54.7+dfsg-1~deb12u1
ii  python3-gi-cairo  3.42.2-3+b1

-- no debconf information
diff --git a/test_scour.py b/test_scour.py
index 76f1983..549333f 100755
--- a/test_scour.py
+++ b/test_scour.py
@@ -606,6 +606,7 @@ class 
KeepInkscapeNamespaceDeclarationsWhenKeepEditorData(unittest.TestCase):
                 break
         self.assertEqual(True, FoundNamespace,
                          "Did not find Inkscape namespace declaration when 
using --keep-editor-data")
+        return False
 
 
 class KeepSodipodiNamespaceDeclarationsWhenKeepEditorData(unittest.TestCase):
@@ -621,6 +622,7 @@ class 
KeepSodipodiNamespaceDeclarationsWhenKeepEditorData(unittest.TestCase):
                 break
         self.assertEqual(True, FoundNamespace,
                          "Did not find Sodipodi namespace declaration when 
using --keep-editor-data")
+        return False
 
 
 class KeepReferencedFonts(unittest.TestCase):

Reply via email to