Hello there,

as this upload was regressing on autopackage tests, Kevin and I have worked 
towards an updated version, to fix the upgrading hiccups it caused.

I've uploaded the attached debdiff and pushed these changes to
https://salsa.debian.org/debian/dictd/-/merge_requests/5 too.

I'll comment on the two bugs with ideas on how to move forward.

Best,
OdyX

Le vendredi, 21 novembre 2025, 09.07:32 h heure normale d’Europe centrale 
Didier 'OdyX' Raboud a écrit :
> Control: tags -1 +patch +pending
> 
> Hello there Sven, Kevin & Robert,
> 
> thanks to your groundwork to provide the systemd unit files, Kevin has
> worked towards packaging them and integrating them to form a working NMU to
> fix this long-standing serious bug.
> 
> The full debdiff is attached, which includes the unit files from Sven and
> further integration work from Kevin, which I have reviewed and pushed to
> https://salsa.debian.org/debian/dictd/-/merge_requests/4 as well.
> 
> I have sponsored his NMU to the DELAYED/2 queue and it will land in unstable
> after this delay. Feel free to accelerate the upload as you see fit.
> 
> Many thanks to Kevin for his work on this, and to Sven for providing the
> systemd unit files.
> 
> Best,
> 
> OdyX

-- 
    OdyX
diff -Nru dictd-1.13.1+dfsg/debian/changelog dictd-1.13.1+dfsg/debian/changelog
--- dictd-1.13.1+dfsg/debian/changelog	2025-11-21 08:14:35.000000000 +0100
+++ dictd-1.13.1+dfsg/debian/changelog	2025-12-05 09:16:15.000000000 +0100
@@ -1,3 +1,20 @@
+dictd (1.13.1+dfsg-1.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+
+  [ Kevin Mueller ]
+  * systemd integration:
+    - drop User= / Group= to reinstate privilege logic the init script always
+      had
+    - in dictd.config: replace systemctl with deb-systemd-invoke and keep
+      invoke-rc.d fallback (fixes autopkgtests' regression)
+
+  [ Didier Raboud ]
+  * systemd integration: allow burst service restarts (for upgrades)
+    (Closes: #1066189, #1121708)
+
+ -- Didier Raboud <[email protected]>  Fri, 05 Dec 2025 09:16:15 +0100
+
 dictd (1.13.1+dfsg-1.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru dictd-1.13.1+dfsg/debian/dictd.config dictd-1.13.1+dfsg/debian/dictd.config
--- dictd-1.13.1+dfsg/debian/dictd.config	2025-11-21 08:14:35.000000000 +0100
+++ dictd-1.13.1+dfsg/debian/dictd.config	2025-12-05 08:56:32.000000000 +0100
@@ -32,9 +32,13 @@
 # Make dpkg-reconfigure stop the dictd server before
 # /etc/default/dictd is modified by the postinst script.
 if [ "$1" = "reconfigure" ] && [ "$RUN_MODE" = "daemon" ]; then
-    if [ -d /run/systemd/system ] && command -v systemctl >/dev/null; then
-        systemctl stop dictd.service >&2 || echo "Warning: failed to stop dictionary server" >&2
+    if [ -d /run/systemd/system ] && command -v deb-systemd-invoke >/dev/null; then
+        # Systemd system: use deb-systemd-invoke instead of calling systemctl directly.
+        deb-systemd-invoke stop dictd.service >/dev/null 2>&1 \
+            || echo "Warning: failed to stop dictionary server" >&2
     elif [ -x "$INITFILE" ] && command -v invoke-rc.d >/dev/null; then
-        invoke-rc.d dictd stop >&2 || echo "Warning: failed to stop dictionary server" >&2
+        # Non-systemd: fall back to sysv init script via invoke-rc.d.
+        invoke-rc.d dictd stop >/dev/null 2>&1 \
+            || echo "Warning: failed to stop dictionary server" >&2
     fi
 fi
diff -Nru dictd-1.13.1+dfsg/debian/dictd.service dictd-1.13.1+dfsg/debian/dictd.service
--- dictd-1.13.1+dfsg/debian/dictd.service	2025-11-21 08:14:35.000000000 +0100
+++ dictd-1.13.1+dfsg/debian/dictd.service	2025-12-05 09:13:10.000000000 +0100
@@ -7,8 +7,6 @@
 Type=forking
 EnvironmentFile=-/etc/default/dictd
 
-User=dictd
-Group=dictd
 # Let systemd create /run/dictd owned by dictd:dictd
 RuntimeDirectory=dictd
 RuntimeDirectoryMode=0755
@@ -20,6 +18,8 @@
 ExecReload=/bin/kill -HUP $MAINPID
 
 Restart=on-failure
+# Allow burst service restarts (useful in upgrades)
+StartLimitIntervalSec=0
 
 [Install]
 WantedBy=multi-user.target
\ No newline at end of file

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to