Control: found -1 11.9.0-2 On Sat, 2016-10-29 at 12:06 +0100, Ian Jackson wrote: > While debugging a build problem, I discovered this curious fact: > > The libvirt configure script checks for the existence of a directory > called .git, and if so it: > - enables building the test suite > - adds -Werror to the build flags > > I can sort of see why upstream might think these useful but in the > Debian context I don't think I agree. > > I suggest passing to configure from debian/rules, > --with-test-suite > --disable-werror
Although the build system has changed since 2016, I just discovered that unfortunately this curious fact has not. The .git-dependent behavior can now be avoided by adding -Dgit_werror=disabled -Dexpensive_tests=enabled [1][2] to @DEB_CONFIGURE_EXTRA_ARGS@ for dh_auto_configure/meson. Generating dist files (libvirt.spec and AUTHORS.rst) is also .git-dependent[3] but I'm unsure whether this is an issue in practice. Cheers, Kevin [1]: https://salsa.debian.org/libvirt-team/libvirt/-/blob/debian/11.9.0-2/meson.build?ref_type=tags#L241 [2]: https://salsa.debian.org/libvirt-team/libvirt/-/blob/debian/11.9.0-2/meson.build?ref_type=tags#L2058 [3]: https://salsa.debian.org/libvirt-team/libvirt/-/blob/debian/11.9.0-2/meson.build?ref_type=tags#L2155
