Hello, Andree Leidenfrost said on Sat, Jun 24, 2006 at 01:49:20PM +1000:
> [Bruno: As usual my request for approval. Fairly obvious and low risk I
> believe. Can I submit attached patch to stable?]
Yep. I generally use egrep myself rather than grep -E, but they are
similar (from the man page).
~/mondo/svn/branches/stable > grep -r egrep . | grep -v \.svn
./mindi/mindi: tr ' ' '\n' < $outfile.pre | tr -s '/' '/' | fgrep -vx "" |
sort -u | egrep -v "/libX11|/libXext|/libXi|/libgtk|/libgdk" > $outfile
./mindi/mindi: | egrep -v "((none|/tmp|/ISOs|/proc|/dev/root) )|/mnt/" \
./mindi/mindi: j=`find $imagesdir -type f | fgrep "/mindi-boot" | egrep -v
'2880|5760'`
./mindi/mindi: for fname in `find $root -maxdepth 2 -type f | fgrep lin |
egrep -v '^/proc/|^/net/'` ; do
./mindi/mindi:[ -f "$MINDI_LIB/vmlinuz" ] && FAILSAFE_KVER=`strings
$MINDI_LIB/vmlinuz 2> /dev/null | egrep "2\.[46]" | cut -d' ' -f1`
./mondo/mondo/common/libmondo-devices.c: ("parted2fdisk -l
2>/dev/null | grep '^/dev/' | egrep -qv '(MS|DOS|FAT|NTFS)'");
[...]
So if you don't mind, I would prefer to standardize on this, except if
you prefer to do the reverse (change all occurences of egrep with grep
-E)
Anyway, a patch such as the one you propose, should go in SVN clearly.
Bruno.
--
Linux Profession Lead EMEA / Open Source Evangelist \ HP C&I EMEA IET
http://www.mondorescue.org / HP/Intel Solution Center \ http://hpintelco.net
Des infos sur Linux? http://www.HyPer-Linux.org http://www.hp.com/linux
La musique ancienne? http://www.musique-ancienne.org http://www.medieval.org
pgpSSH2QKtW6X.pgp
Description: PGP signature
