Control: tags -1 = patch upstream
On Sun, 05 Apr 2020 at 14:46:15 +0100, Simon McVittie wrote:
This package Build-Depends on libdbus-glib-1-dev, but it looks as though
all its D-Bus bits are implemented using either GLib's GDBus (part of
libglib2.0-0) or the dbus-send(1) command-line tool. If this analysis
is correct, please remove the Build-Depends on libdbus-glib-1-dev.
It looks like that guess was correct. The attached patch
0001-d-control-d-patches-Stop-depending-on-dbus-glib.patch builds
successfully and does not change the contents of the binary package
(verified with diffoscope); I haven't tested it beyond that.
I haven't checked whether lxsession is missing a dependency on
dbus-send. It would probably be a good idea to add one, but that is
out-of-scope for this particular bug report.
On Mon, 25 May 2020 at 21:07:30 +0900, Kentaro Hayashi wrote:
It seems that this bug is already fixed in upstream
https://git.lxde.org/gitweb/?p=debian/lxsession.git;a=commit;h=612ac4cd55214a280638f1bf062e40e2d6f1ff7a
It was not: the upstream code still had an unused reference to
dbus-glib. Please forward the attached patch
"build-Remove-a-leftover-reference-to-dbus-glib.patch" upstream.
smcv
>From 31e1e73e9f2709da2688536d63bcfb711be5cb18 Mon Sep 17 00:00:00 2001
From: Simon McVittie <[email protected]>
Date: Thu, 28 Aug 2025 09:22:00 +0100
Subject: [PATCH] d/control, d/patches: Stop depending on dbus-glib
Closes: #955865
---
debian/control | 1 -
...ve-a-leftover-reference-to-dbus-glib.patch | 24 +++++++++++++++++++
debian/patches/series | 1 +
3 files changed, 25 insertions(+), 1 deletion(-)
create mode 100644 debian/patches/build-Remove-a-leftover-reference-to-dbus-glib.patch
diff --git a/debian/control b/debian/control
index 805144f..924df85 100644
--- a/debian/control
+++ b/debian/control
@@ -8,7 +8,6 @@ Uploaders: Andrew Lee (李健秋) <[email protected]>,
Build-Depends: debhelper-compat (= 13),
docbook-xml,
intltool,
- libdbus-glib-1-dev,
libgtk-3-dev,
libpolkit-agent-1-dev,
valac,
diff --git a/debian/patches/build-Remove-a-leftover-reference-to-dbus-glib.patch b/debian/patches/build-Remove-a-leftover-reference-to-dbus-glib.patch
new file mode 100644
index 0000000..5698d84
--- /dev/null
+++ b/debian/patches/build-Remove-a-leftover-reference-to-dbus-glib.patch
@@ -0,0 +1,24 @@
+From: Simon McVittie <[email protected]>
+Date: Thu, 28 Aug 2025 09:20:18 +0100
+Subject: build: Remove a leftover reference to dbus-glib
+
+Bug-Debian: https://bugs.debian.org/955865
+Fixes: 99480050 "Stop using directly dbus and dbus-glib, we are using gdbus"
+Fixes: f7b3ba5a "Remove remaining dbus-glib flag"
+Signed-off-by: Simon McVittie <[email protected]>
+---
+ Makefile.am | 1 -
+ 1 file changed, 1 deletion(-)
+
+diff --git a/Makefile.am b/Makefile.am
+index 210cc79..5208e8c 100644
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -418,7 +418,6 @@ lxsession_lxsession_SOURCES = \
+
+ lxsession_lxsession_VALAFLAGS = \
+ --vapidir=$(srcdir)/vapi \
+- --pkg dbus-glib-1 \
+ --pkg gio-2.0 \
+ --pkg posix \
+ --pkg lxsettings-daemon \
diff --git a/debian/patches/series b/debian/patches/series
index 7602d08..cb46304 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,2 +1,3 @@
00-disable-dpkg-access.patch
01-check-fix.patch
+build-Remove-a-leftover-reference-to-dbus-glib.patch
--
2.51.0
From: Simon McVittie <[email protected]>
Date: Thu, 28 Aug 2025 09:20:18 +0100
Subject: build: Remove a leftover reference to dbus-glib
Bug-Debian: https://bugs.debian.org/955865
Fixes: 99480050 "Stop using directly dbus and dbus-glib, we are using gdbus"
Fixes: f7b3ba5a "Remove remaining dbus-glib flag"
Signed-off-by: Simon McVittie <[email protected]>
---
Makefile.am | 1 -
1 file changed, 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 210cc79..5208e8c 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -418,7 +418,6 @@ lxsession_lxsession_SOURCES = \
lxsession_lxsession_VALAFLAGS = \
--vapidir=$(srcdir)/vapi \
- --pkg dbus-glib-1 \
--pkg gio-2.0 \
--pkg posix \
--pkg lxsettings-daemon \
