On Tue, Aug 19, 2025 at 06:46:41PM +0200, Michael Biebl wrote: > > Am 19.08.25 um 18:29 schrieb Roberto C. Sánchez: > > On Tue, Aug 19, 2025 at 02:08:59PM +0200, Michael Biebl wrote: > > > > https://salsa.debian.org/debian/rsyslog/-/commit/8ea8f59756eccfae4471e7482460e922750f169c > > > > > > This was basically all I needed to make rsyslog compile against against > > > v2. > > > Is there more that I need to consider (deprecated APIs etc.), if so, do > > > you > > > have recommendations, links to a migration guide, etc. > > > > > > > That change looks right to me. Basically, if something was already > > successfully building against 1.30.x (without using any deprecated APIs) > > then building against 2.x is a matter of just using the new module name > > (whether via pkg-config or CMake). > > > > The SONAME bump was about finally dropping a bunch of long deprecated > > things from the API. Apart from the module name change (and some minor > > reshulffling of headers), there weren't any really notable changes to > > the API. > > Thanks for that additional information. > > The patch I applied to Debian is a bit more convoluted than necessary as I > also sent it upstream who wants to keep the package building on really old > versions on Ubuntu and CentOS.
That's understandable. > And I was a bit worried by that comment in > > https://github.com/rsyslog/rsyslog/pull/5958#pullrequestreview-3126270761 > > > However, the implementation is incomplete and will lead to a build > > failure when using mongo-c-driver v2. A critical part of the C code > > still uses a function that has been removed in v2. > > I suppose AI was just lying to me then :-) > Yeah, that seems a bit suspicious to me. Regards, -Roberto -- Roberto C. Sánchez
