Control: tag 1097999 patch

On Mon, Feb 17, 2025 at 05:57:14PM +0000, Matthias Klose wrote:
> [...]
> The package fails to build in a test rebuild on at least amd64 with
> gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
> severity of this report will be raised before the forky release.
> [...]
> src/time.c:750:20: error: assignment to 'sighandler' {aka 'void (*)(void)'} 
> from incompatible pointer type '__sighandler_t' {aka 'void (*)(int)'} 
> [-Wincompatible-pointer-types]
>   750 |   interrupt_signal = signal (SIGINT, SIG_IGN);
>       |                    ^
> [...]
> src/time.c:751:15: error: assignment to 'sighandler' {aka 'void (*)(void)'} 
> from incompatible pointer type '__sighandler_t' {aka 'void (*)(int)'} 
> [-Wincompatible-pointer-types]
>   751 |   quit_signal = signal (SIGQUIT, SIG_IGN);
> [...]
> /usr/include/signal.h:88:57: note: expected '__sighandler_t' {aka 'void 
> (*)(int)'} but argument is of type 'sighandler' {aka 'void (*)(void)'}
>    88 | extern __sighandler_t signal (int __sig, __sighandler_t __handler)
>       |                                          ~~~~~~~~~~~~~~~^~~~~~~~~
> [...]

A patch fixing this has been proposed in
<https://lists.gnu.org/archive/html/bug-time/2025-01/msg00000.html>.
Here copied for reference:

| Signed-off-by: Ondřej Pohořelský <[email protected]>
| ---
|  src/time.c | 2 +-
|  1 file changed, 1 insertion(+), 1 deletion(-)
| 
| diff --git a/src/time.c b/src/time.c
| index 7b401bc..c8d7ab0 100644
| --- a/src/time.c
| +++ b/src/time.c
| @@ -803,7 +803,7 @@ run_command (cmd, resp)
|       RESUSE *resp;
|  {
|    pid_t pid; /* Pid of child.  */
| -  sighandler interrupt_signal, quit_signal;
| +  __sighandler_t interrupt_signal, quit_signal;
|    int saved_errno;
| 
|    resuse_start (resp);
| --
| 2.48.1

HTH,
Flo

Attachment: signature.asc
Description: PGP signature

Reply via email to