Source: swupdate
Version: 2024.12.1+dfsg-1
Severity: normal
Tags: patch
X-Debbugs-Cc: quirin.gylsto...@siemens.com

Dear Maintainer,

During testing of SWUpdate the service was restarted with `systemctl
restart swupdate` aftwards the RuntimeDirectory /run/swupdate no longer
contained the sockets /run/swupdate/sockinstctrl, /run/swupdate/swupdateprog.

This behavior only occurs after the socket was created by
swupdate.socket.

Attached is the necessary patch to preserve the SWUpdate sockets during
service restarts.


Quirin

-- System Information:
Debian Release: 12.11
  APT prefers testing-security
  APT policy: (500, 'testing-security'), (500, 'stable-updates'), (500, 
'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.12.30-amd64 (SMP w/16 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
>From c2deee7dc465979b73fbe32872f4133ee6b62861 Mon Sep 17 00:00:00 2001
From: Quirin Gylstorff <quirin.gylsto...@siemens.com>
Date: Tue, 1 Jul 2025 17:32:31 +0200
Subject: [PATCH] Preserve the runtime directory during a service restart

The runtime directory is deleted during a service restart but
the socket is not automatically restarted and therefore the
sockets are not recreated.

Signed-off-by: Quirin Gylstorff <quirin.gylsto...@siemens.com>
---
 debian/swupdate.service | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/swupdate.service b/debian/swupdate.service
index 42b07b7e..4418b6f7 100644
--- a/debian/swupdate.service
+++ b/debian/swupdate.service
@@ -5,6 +5,7 @@ Documentation=https://sbabic.github.io/swupdate
 
 [Service]
 RuntimeDirectory=swupdate
+RuntimeDirectoryPreserve=restart
 Type=notify
 ExecStart=/usr/lib/swupdate/swupdate.sh
 KillMode=mixed
-- 
2.47.0

>From c2deee7dc465979b73fbe32872f4133ee6b62861 Mon Sep 17 00:00:00 2001
From: Quirin Gylstorff <quirin.gylsto...@siemens.com>
Date: Tue, 1 Jul 2025 17:32:31 +0200
Subject: [PATCH] Preserve the runtime directory during a service restart

The runtime directory is deleted during a service restart but
the socket is not automatically restarted and therefore the
sockets are not recreated.

Signed-off-by: Quirin Gylstorff <quirin.gylsto...@siemens.com>
---
 debian/swupdate.service | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/swupdate.service b/debian/swupdate.service
index 42b07b7e..4418b6f7 100644
--- a/debian/swupdate.service
+++ b/debian/swupdate.service
@@ -5,6 +5,7 @@ Documentation=https://sbabic.github.io/swupdate
 
 [Service]
 RuntimeDirectory=swupdate
+RuntimeDirectoryPreserve=restart
 Type=notify
 ExecStart=/usr/lib/swupdate/swupdate.sh
 KillMode=mixed
-- 
2.47.0

Reply via email to