Le dim. 6 juil. 2025 à 08:13, Yadd <y...@debian.org> a écrit : > On 7/5/25 15:32, Paul Gevers wrote: > > Source: node-superagent > > Version: 9.0.1-1 > > Severity: serious > > User: debian...@lists.debian.org > > Usertags: regression > > > > Dear maintainer(s), > > > > Your package has an autopkgtest, great. However, it fails since June > > 2025. Can you please investigate the situation and fix it? I copied some > > of the output at the bottom of this report. > > > > The release team has announced [1] that failing autopkgtest on amd64 and > > arm64 are considered RC in testing. > > > > More information about this bug and the reason for filing it can be > > found on https://wiki.debian.org/ContinuousIntegration/ > > RegressionEmailInformation > > > > With my Release Team member hat on I allow you to tag this bug as > > trixie-ignore if this is nearly completely a test issue as it's so late > > in the freeze and it's not worth removing the package from trixie > > because of a failing test at this moment unless it exposes a much bigger > > issue. Having said that, if this is a test only issue and a fix is > > possible without fully removing the autopkgtest and without making the > > test superficial, it's still welcome, but it would need to happen soon. > > > > Paul > > > > [1] https://lists.debian.org/debian-devel-announce/2019/07/msg00002.html > > > > https://ci.debian.net/data/autopkgtest/testing/amd64/n/node- > > superagent/62133275/log.gz > > > > 105s 1) Agent > > 105s should remember defaults: > > 105s > > 105s AssertionError [ERR_ASSERTION]: 0 == 1 > > 105s + expected - actual > > 105s > > 105s -0 > > 105s +1 > > 105s > > 105s at Context.<anonymous> (test/agent-base.js:33:12) > > 105s at callFn (/usr/share/nodejs/mocha/lib/runnable.js:364:21) > > 105s at Runnable.run > (/usr/share/nodejs/mocha/lib/runnable.js:352:5) > > 105s at Runner.runTest > (/usr/share/nodejs/mocha/lib/runner.js:677:10) > > 105s at /usr/share/nodejs/mocha/lib/runner.js:800:12 > > 105s at next (/usr/share/nodejs/mocha/lib/runner.js:592:14) > > 105s at /usr/share/nodejs/mocha/lib/runner.js:602:7 > > 105s at next (/usr/share/nodejs/mocha/lib/runner.js:485:14) > > 105s at Immediate._onImmediate (/usr/share/nodejs/mocha/lib/ > > runner.js:570:5) > > 105s at process.processImmediate (node:internal/timers:483:21) > > 105s > > 105s > > 105s > > 105s autopkgtest [13:05:26]: test pkg-js-autopkgtest: > > -----------------------] > Hi Jérémy, > > the broken test is test/agent-base.js, even with more recent > node-superagent and a "npm instll", test still fail. > > The problem is that the initialization of "agent" return undefined when > ".query({ hello: 'world' })" is set. I can fix this with this: > > > const agent = request > .agent() > .accept('json') > .use(() => { > console.error('called_use'); > called++; > }) > .once('request', () => { > console.error('called_request'); > event_called++; > }) > // DISABLED HERE > // .query({ hello: 'world' }) > .set('X-test', 'testing'); > > return agent > .get(`${base}/echo`) > // ADDED HERE > .query({ hello: 'world' }) > .then((res) => { > assert.equal(1, called); > assert.equal(1, event_called); > assert.equal('application/json', res.headers.accept); > assert.equal('testing', res.headers['x-test']); > > return agent.get(`${base}/querystring`) > // ADDED HERE ALSO > .query({hello:'world'}); > }) > .then((res) => { > assert.equal(2, called); > assert.equal(2, event_called); > assert.deepEqual({ hello: 'world' }, res.body); > }); > > but then it proves the reverse than wanted: 'should remember defaults' > becomes 'no rememebr default' or 'unable to set default' > > Is there a change in Nodejs "http" object ? >
Yes, there is. This returns a new QUERY method now. I'm doing a patch right now.