tags 1106425 + patch
thanks
gregor herrmann wrote:
> Apparently redis' error message changed (again, this was already seen
> in https://github.com/typester/Test-RedisServer/issues/12 ).
> Or it fails earlier now because of a different problem … [0]
Pretty certain it's the former:
$ echo "unknown_key unknown_val" > broken.conf
$ redis-server ./broken.conf
[…]
112711:M 28 May 2025 15:03:06.018 # Unresolved Configuration(s) Detected:
112711:M 28 May 2025 15:03:06.018 # >>> 'unknown_key unknown_val'
112711:M 28 May 2025 15:03:06.018 # Module Configuration detected without
loadmodule directive or no ApplyConfig call: aborting
Looks like this is actually the _module_ subsystem making the
complaint here, so I think we should accept both styles of error
message. After all, upstream may be tempted to address the opaqueness
of this message in future versions.
A patch is attached that accepts this alternative style of error as well.
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / chris-lamb.co.uk
`-
diff --git t/unknown_conf.t t/unknown_conf.t
index bb2f423..0583b9a 100644
--- t/unknown_conf.t
+++ t/unknown_conf.t
@@ -15,6 +15,6 @@ eval {
ok !$server, 'server did not initialize ok';
-like $@, qr/\*\*\* FATAL CONFIG FILE ERROR( \([^\)]+\))? \*\*\*/, 'error msg
ok';
+like $@, qr/(?:\*\*\* FATAL CONFIG FILE ERROR( \([^\)]+\))? \*\*\*|Module
Configuration detected without loadmodule directive or no ApplyConfig call:
aborting)/, 'error msg ok';
done_testing;
