Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian....@packages.debian.org
Usertags: pu
X-Debbugs-Cc: insighttoolk...@packages.debian.org, sanv...@debian.org
Control: affects -1 + src:insighttoolkit5
[ Reason ]
Fix Bug #1105896 FTBFS: Test itkOptImageToImageMetricsTest04 fails on
single-cpu systems
[ Impact ]
Without this update, not everybody will be able to build the package.
[ Tests ]
I've checked that the package builds again for everybody.
[ Risks ]
Very low. No real code changes. The change just removes a few lines in one
test, and it has
been already merged upstream.
[ Checklist ]
[X] *all* changes are documented in the d/changelog
[X] I reviewed all changes and I approve them
[X] attach debdiff against the package in (old)stable
[X] the issue is verified as fixed in unstable
[ Changes ]
Add patch 0004-fix-itkOptImageToImageMetricsTest04.patch, cherry-picked from
upstream.
[ Other info ]
I've already uploaded the package for bookworm.
I will also prepare an upload for insighttoolkit4, as it has the same
bug and it's fixed in the same way.
diff -Nru insighttoolkit5-5.2.1/debian/changelog
insighttoolkit5-5.2.1/debian/changelog
--- insighttoolkit5-5.2.1/debian/changelog 2022-05-18 22:54:03.000000000
+0200
+++ insighttoolkit5-5.2.1/debian/changelog 2025-05-22 14:15:00.000000000
+0200
@@ -1,3 +1,11 @@
+insighttoolkit5 (5.2.1-5+deb12u1) bookworm; urgency=medium
+
+ * Team upload.
+ * Make itkOptImageToImageMetricsTest04 not to fail on single-CPU systems.
+ Closes: #1105896.
+
+ -- Santiago Vila <sanv...@debian.org> Thu, 22 May 2025 14:15:00 +0200
+
insighttoolkit5 (5.2.1-5) unstable; urgency=medium
* d/control: apply Multi-Arch: foreign to insighttoolkit5-examples.
diff -Nru
insighttoolkit5-5.2.1/debian/patches/0004-fix-itkOptImageToImageMetricsTest04.patch
insighttoolkit5-5.2.1/debian/patches/0004-fix-itkOptImageToImageMetricsTest04.patch
---
insighttoolkit5-5.2.1/debian/patches/0004-fix-itkOptImageToImageMetricsTest04.patch
1970-01-01 01:00:00.000000000 +0100
+++
insighttoolkit5-5.2.1/debian/patches/0004-fix-itkOptImageToImageMetricsTest04.patch
2025-05-22 14:15:00.000000000 +0200
@@ -0,0 +1,25 @@
+From: Niels Dekker <n.dek...@lumc.nl>
+Subject: Make itkOptImageToImageMetricsTest04 not to fail on single-CPU systems
+Bug-Debian: https://bugs.debian.org/1105896
+Origin:
https://github.com/InsightSoftwareConsortium/ITK/commit/57b138cf150e097340b75e7f37eee061da80c627
+Last-Update: 2025-05-16
+
+--- a/Modules/Nonunit/Review/test/itkOptImageToImageMetricsTest2.h
++++ b/Modules/Nonunit/Review/test/itkOptImageToImageMetricsTest2.h
+@@ -81,16 +81,6 @@
+ // so we seed the random number generator
+ // immediately before this call.
+ metric->Initialize();
+-
+- // Verify that Initialize has properly called
+- // MultiThreadingInitialize() and a series of CreateAnother();
+-
+- using TransformPointer = typename MetricType::TransformPointer;
+- const TransformPointer * transformPtr = metric->GetThreaderTransform();
+- if ((transformPtr == static_cast<const TransformPointer *>(nullptr)) ||
(transformPtr[0].IsNull()))
+- {
+- exit(EXIT_FAILURE);
+- }
+ }
+ // Other registration functionality tested in
+ // OptImageToImageTest.cxx... skip the rest
diff -Nru insighttoolkit5-5.2.1/debian/patches/series
insighttoolkit5-5.2.1/debian/patches/series
--- insighttoolkit5-5.2.1/debian/patches/series 2022-05-18 22:54:03.000000000
+0200
+++ insighttoolkit5-5.2.1/debian/patches/series 2025-05-22 14:15:00.000000000
+0200
@@ -1,3 +1,4 @@
0001-Fix-building-and-running-with-system-MINC.patch
0002-Do-not-unconditionally-enable-SSE-for-i386.patch
0003-Modules-Core-Common-src-CMakeLists.txt-Use-UTC-times.patch
+0004-fix-itkOptImageToImageMetricsTest04.patch
