Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: insighttoolk...@packages.debian.org, sanv...@debian.org
Control: affects -1 + src:insighttoolkit5
Please unblock package insighttoolkit5
[ Reason ]
Fix Bug #1105896 FTBFS: Test itkOptImageToImageMetricsTest04 fails on
single-cpu systems
[ Impact ]
Without this update, not everybody will be able to build the package.
[ Tests ]
I've checked that the package builds again for everybody.
[ Risks ]
Very low. No real code changes. The change just removes a few lines in one
test, and it has
been already merged upstream.
[ Checklist ]
[X] all changes are documented in the d/changelog
[X] I reviewed all changes and I approve them
[X] attach debdiff against the package in testing
unblock insighttoolkit5/5.2.1-5
diff -Nru insighttoolkit5-5.4.3/debian/changelog
insighttoolkit5-5.4.3/debian/changelog
--- insighttoolkit5-5.4.3/debian/changelog 2025-04-22 06:48:27.000000000
+0200
+++ insighttoolkit5-5.4.3/debian/changelog 2025-05-22 00:40:00.000000000
+0200
@@ -1,3 +1,12 @@
+insighttoolkit5 (5.4.3-5) unstable; urgency=medium
+
+ * Team upload.
+ * Make itkOptImageToImageMetricsTest04 not to fail on single-CPU systems.
+ Closes: #1105896.
+ * Update standards-version.
+
+ -- Santiago Vila <sanv...@debian.org> Thu, 22 May 2025 00:40:00 +0200
+
insighttoolkit5 (5.4.3-4) unstable; urgency=medium
[ Steve Robbins ]
diff -Nru insighttoolkit5-5.4.3/debian/control
insighttoolkit5-5.4.3/debian/control
--- insighttoolkit5-5.4.3/debian/control 2025-04-22 06:48:27.000000000
+0200
+++ insighttoolkit5-5.4.3/debian/control 2025-05-22 00:40:00.000000000
+0200
@@ -21,7 +21,7 @@
libminc-dev,
libnifti2-dev,
libhdf5-dev
-Standards-Version: 4.6.2
+Standards-Version: 4.7.2
Vcs-Browser: https://salsa.debian.org/med-team/insighttoolkit
Vcs-Git: https://salsa.debian.org/med-team/insighttoolkit.git
Homepage: http://www.itk.org/
diff -Nru
insighttoolkit5-5.4.3/debian/patches/0004-fix-itkOptImageToImageMetricsTest04.patch
insighttoolkit5-5.4.3/debian/patches/0004-fix-itkOptImageToImageMetricsTest04.patch
---
insighttoolkit5-5.4.3/debian/patches/0004-fix-itkOptImageToImageMetricsTest04.patch
1970-01-01 01:00:00.000000000 +0100
+++
insighttoolkit5-5.4.3/debian/patches/0004-fix-itkOptImageToImageMetricsTest04.patch
2025-05-22 00:40:00.000000000 +0200
@@ -0,0 +1,25 @@
+From: Niels Dekker <n.dek...@lumc.nl>
+Subject: Make itkOptImageToImageMetricsTest04 not to fail on single-CPU systems
+Bug-Debian: https://bugs.debian.org/1105896
+Origin:
https://github.com/InsightSoftwareConsortium/ITK/commit/57b138cf150e097340b75e7f37eee061da80c627
+Last-Update: 2025-05-16
+
+--- a/Modules/Nonunit/Review/test/itkOptImageToImageMetricsTest2.h
++++ b/Modules/Nonunit/Review/test/itkOptImageToImageMetricsTest2.h
+@@ -81,16 +81,6 @@
+ // so we seed the random number generator
+ // immediately before this call.
+ metric->Initialize();
+-
+- // Verify that Initialize has properly called
+- // MultiThreadingInitialize() and a series of CreateAnother();
+-
+- using TransformPointer = typename MetricType::TransformPointer;
+- const TransformPointer * transformPtr = metric->GetThreaderTransform();
+- if ((transformPtr == static_cast<const TransformPointer *>(nullptr)) ||
(transformPtr[0].IsNull()))
+- {
+- exit(EXIT_FAILURE);
+- }
+ }
+ // Other registration functionality tested in
+ // OptImageToImageTest.cxx... skip the rest
diff -Nru insighttoolkit5-5.4.3/debian/patches/series
insighttoolkit5-5.4.3/debian/patches/series
--- insighttoolkit5-5.4.3/debian/patches/series 2025-04-22 06:48:27.000000000
+0200
+++ insighttoolkit5-5.4.3/debian/patches/series 2025-05-22 00:40:00.000000000
+0200
@@ -1,3 +1,4 @@
0001-Fix-building-and-running-with-system-MINC.patch
0002-fix-build-gcc15.patch
0003-fix-fftw-include.patch
+0004-fix-itkOptImageToImageMetricsTest04.patch
