Hi Sean, Sean Whitton <spwhit...@spwhitton.name> writes:
> Hello,
>
> On Wed 21 May 2025 at 01:54pm +09, David Bremner wrote:
>
>> Xiyue Deng <manp...@gmail.com> writes:
>>
>>>>
>>>> Is it sufficient to check the top level? what if there is deeper nested
>>>> directories? Apologies if I missed some context.
>>>>
>>>
>>> Before 2.1.1, the install script only creates symlinks for everything on
>>> the top level (see code for release 2.1.1[1]). Therefore I think
>>> handling top level should be sufficient.
>>>
>>
>> OK. Then 'find "${elcdir}" -maxdepth 1 -type l -delete'
>> seems simpler / safer then the script, but if you and Sean
>> are happier with the script (fragment), then that's fine.
>
> I don't have opinions on this except for generally agreeing with
> preferring find(1) over custom shell scripting.
>
Just to be accurate, the custom script checks whether a symlink is
pointing to a directory and removes it when true, while "find" removes
all symlinks (both for top level). But since we are recreating the
symlinks anyway it's functionally equivalent on handling this case.
I have now squashed the 2 commits and updated d/changelog accordingly.
--
Regards,
Xiyue Deng
signature.asc
Description: PGP signature
