Control: block 1100073 by -1
On Fri, 19 Jan 2024 19:22:27 +0100 Nicolas Peugnet <n.peug...@free.fr>
wrote:
On Thu, 8 Apr 2021 21:56:35 +0100 Rock Storm <rockst...@gmx.com> wrote:
> Hi Nilesh,
>
> Thank you for you offer. I'm sorry, I completely forgot about this bugs.
> I wanted these libraries (#921150 and #922528) to be uploaded in order
> to package the latest 'arduino-builder'. However, we finally decided to
> keep the current version since 'arduino-builder' will be superseded by
> 'arduino-cli' in the near future anyway.
>
> I would not close the ITPs nor remove the work from Salsa since I suspect
> they will be necessary for 'arduino-cli' though I haven't looked into
> this yet. I guess the RFS (#934515) could be closed as "wontfix" and/or
> tagged as "bullseye-ignore" and simply left open for later. I'm easy.
Hi,
I would be very interested by the addition of 'arduino-cli' to the
Debian repository. Indeed, the now deprecated 'arduino-builder' does not
support newer Arduino boards like the Nano 33 family and I suspect more
of them.
It seems the 'arduino-cli' package is nearing a 1.0.0 stable release,
and it is already a very capable tool, so it might be interesting to
start packaging its dependencies.
I don't think I will be able to help packaging, but I could help testing
packages for sure.
--
Hi all,
I'm also interested in getting this into Debian. I looked at
paths-helper, and I ran into a build-time test failure:
dh_auto_test -O--builddirectory=_build -O--buildsystem=golang
cd _build && go test -vet=off -v -p 14
github.com/arduino/go-paths-helper
=== RUN TestGzipGunzip
--- PASS: TestGzipGunzip (0.00s)
=== RUN TestListConstructors
--- PASS: TestListConstructors (0.00s)
=== RUN TestListSorting
--- PASS: TestListSorting (0.00s)
=== RUN TestListFilters
--- PASS: TestListFilters (0.00s)
=== RUN TestPathNew
--- PASS: TestPathNew (0.00s)
=== RUN TestPath
--- PASS: TestPath (0.00s)
=== RUN TestResetStatCacheWhenFollowingSymlink
--- PASS: TestResetStatCacheWhenFollowingSymlink (0.00s)
=== RUN TestIsInsideDir
--- PASS: TestIsInsideDir (0.00s)
=== RUN TestReadFileAsLines
--- PASS: TestReadFileAsLines (0.00s)
=== RUN TestCanonicaTempDir
--- PASS: TestCanonicaTempDir (0.00s)
=== RUN TestCopyDir
--- PASS: TestCopyDir (0.00s)
=== RUN TestParents
--- PASS: TestParents (0.00s)
=== RUN TestFilterDirs
--- PASS: TestFilterDirs (0.00s)
=== RUN TestFilterOutDirs
paths_test.go:313:
Error Trace: /build/reproducible-path/golang-github-arduino-go-paths-helper-1.13.1/_build/src/github.com/arduino/go-paths-helper/paths_test.go:313
Error: "[testdata/broken_symlink/dir_1/file2
testdata/broken_symlink/dir_1/linked_dir testdata/broken_symlink/dir_1/linked_dir/file1
testdata/broken_symlink/dir_1/linked_file testdata/broken_symlink/dir_1/real_dir
testdata/broken_symlink/dir_1/real_dir/file1]" should have 7 item(s), but has 6
Test: TestFilterOutDirs
--- FAIL: TestFilterOutDirs (0.00s)
=== RUN TestEquivalentPaths
--- PASS: TestEquivalentPaths (0.00s)
=== RUN TestCanonicalize
--- PASS: TestCanonicalize (0.00s)
=== RUN TestRelativeTo
--- PASS: TestRelativeTo (0.00s)
=== RUN TestWriteToTempFile
--- PASS: TestWriteToTempFile (0.00s)
=== RUN TestCopyToSamePath
--- PASS: TestCopyToSamePath (0.00s)
=== RUN TestProcessWithinContext
--- PASS: TestProcessWithinContext (0.40s)
=== RUN TestKillProcessGroupOnLinux
--- PASS: TestKillProcessGroupOnLinux (1.00s)
=== RUN TestReadDirRecursive
--- PASS: TestReadDirRecursive (0.00s)
=== RUN TestReadDirRecursiveSymLinkLoop
directories symlink loop detected
directories symlink loop detected
--- PASS: TestReadDirRecursiveSymLinkLoop (0.00s)
=== RUN TestReadDirFiltered
--- PASS: TestReadDirFiltered (0.00s)
=== RUN TestReadDirRecursiveFiltered
--- PASS: TestReadDirRecursiveFiltered (0.00s)
=== RUN TestReadDirRecursiveLoopDetection
readdir_test.go:312:
Error Trace: /build/reproducible-path/golang-github-arduino-go-paths-helper-1.13.1/_build/src/github.com/arduino/go-paths-helper/readdir_test.go:312
Error: "[testdata/loops/regular_3/dir1
testdata/loops/regular_3/dir1/file1 testdata/loops/regular_3/dir2
testdata/loops/regular_3/dir2/dir1 testdata/loops/regular_3/dir2/dir1/file1
testdata/loops/regular_3/dir2/file2]" should have 7 item(s), but has 6
Test: TestReadDirRecursiveLoopDetection
--- FAIL: TestReadDirRecursiveLoopDetection (0.07s)
FAIL
FAIL github.com/arduino/go-paths-helper 1.481s
FAIL
dh_auto_test: error: cd _build && go test -vet=off -v -p 14
github.com/arduino/go-paths-helper returned exit code 1
Does any go expert have an idea as to why ? Looks like IMVHO like a
one-off error.
RockStorm, are you still working on this ? I'd be willing to review and
sponsor the package. Otherwise I might pick it up later.
best,
werdahias
