Hello, On Thu 15 May 2025 at 11:32am +02, Simon Josefsson wrote:
> Package: git-debpush
> Version: 12.12
>
> Here is another small UX improvement idea. On errors it looks like
> this:
>
> jas@kaka:~/dpkg/gsasl$ git debpush -t
> git-debpush: check failed: last upload targeted unstable, now targeting
> experimental; might be a mistake? ('changed-suite' check)
> git-debpush: some check(s) failed; you can pass --force to ignore them
> jas@kaka:~/dpkg/gsasl$
>
> This is very close to a perfect error message but could be improved by
> 1) adding keyword 'error:' so the user understands that this is what
> actually triggers the failure (rather than some unrelated warning), and
> 2) suggest the --force=changed-suite explicitly to make it more
> actionable. So how about:
>
> git-debpush: error: check failed: last upload targeted unstable but now
> targeting experimental; use '--force=changed-suite' to override
>
> The last error line above then becomes a bit redundant and could be
> removed.
I do not want git-debpush to suggest anything other than --force to the
user in its interactive output.
In the code there is a comment about that:
# We don't mention the --force=check options here as those are
# mainly for use by scripts, or when you already know what check
# is going to fail before you invoke git-debpush. Keep the
# script's terminal output as simple as possible. No "see the
# manpage"!
This is an important part of how git-debpush is trying to be different
from dgit. Adding "error:" is fine; I'll do that.
--
Sean Whitton
signature.asc
Description: PGP signature
