Hi Jeroen,
On 15/05/2025 15:36, Jeroen Ploemen wrote:
nice work! Just one minor issue:
* d/copyright lists all contributors and translators as copyright
holders, but those are often listed only as a courtesy or similar
acknowledgement of their efforts. As far as I can tell, the source
code consistently mentions the lead author as the sole copyright
holder, and the translation files also do not contain any copyright
claims.
It makes sense to me. Contributions don't necessarily equal to
copyright, but I usually get asked to add more names, so by habit I just
piled them all in.
You may want to disable the i386 build on the Salsa CI [1], it will
always fail because libpoppler-qt6-dev is missing (as src:poppler
doesn't build a qt6 lib for that architecture anymore [2]).
Done and pipeline is green now.
Thanks for the reference links by the way, I knew the variable was
there, but I would have gone to re-read the salsa recipes to find it.
[1]https://codesearch.debian.net/search?q=SALSA_CI_DISABLE_BUILD_PACKAGE_I386+path%3Adebian&literal=1
[2]https://salsa.debian.org/freedesktop-team/poppler/-/blob/e1669834df5957c4bb826b08b833f84efe27c30a/debian/changelog#L141
Please remove the moreinfo tag (and CC me) once you have an updated
package ready.
--
Regards,
Ahmad
