On 11/05/2025 at 16:53, Cyril Brulebois wrote:
Pascal Hambourg <pas...@plouf.fr.eu.org> (2025-05-11):
The Renesas USB controller seems to work fine without it, and
according to the kernel log, a default firmware is loaded from
non-volatile memory:
xhci-pci-renesas 0000:a3:00.0: failed to load firmware renesas_usb_fw.mem,
*fallback to ROM*
So I think this is the way to go. The fix is trivial, do you wish to
take care of it or shall I prepare a MR ?
That might leave other users on the side of the road, since the ROM
might not be available or might not have been equipped with firmware
data.
You are right, the driver source code confirms it.
Seeing how that particular system would (presumably) work fine without
the check+reload plus how bad the side effects are, it might be prudent
to just ignore renesas_usb_fw.mem / xhci-pci-renesas as a first step.
What about adding an extra check ?
- "failed to load firmware renesas_usb_fw.mem, fallback to ROM" in
kernel messages;
- or some indication in /sys that the driver actually works (in my
experience, just being bound to a device is not reliable enough; maybe
the existence of child devices)
I'm not sure if the iwl-debug-yoyo.bin code is the best way to do that,
but feel free to look into proposing an MR (based or not on that code
path, as you see fit).
This code looks generic enough to be extended. MR opened:
<https://salsa.debian.org/installer-team/hw-detect/-/merge_requests/13>
Felix might want to test the mini-ISO:
<https://salsa.debian.org/pham/hw-detect/-/jobs/7568796/artifacts/file/debian/output/debian-202501XX+salsaci+20250511+10-amd64-gtkmini.iso>
It does not mount the installation media but you can test if it does not
ask for renesas_usb_fw.mem nor unload+reload xhci-pci-renesas. No need
to go further "detect network devices".
For users that would actually miss the firmware (file and/or ROM) and
need it, meaning they would be missing devices, it's important that we
are able to put the finger on the issue.
I agree.
As long as we have the “failed
to load […]” log line on the kernel, and/or whatever “let's ignore this
particular case” in check-missing-firmware, I would consider this topic
covered.
