Don Xu, Review of upload: 2025-02-23 04:11
For information about the tests run, see: https://wiki.debian.org/PhilWyett/DebianMentoring Test 1 (reproducibility): Information only dpkg-buildpackage: info: binary-only upload (no source included) Observed unreproducibility when varying each of the following: fileordering The build is probably reproducible when varying other things. Kathenas: This test is none blocking, but still of importance. Test 3 (build twice): Information only dpkg-source: info: local changes detected, the modified files are: pay-respects-0.6.13/.cargo/config.toml pay-respects-0.6.13/module-request-ai/src/locale.rs dpkg-source: hint: make sure the version in debian/changelog matches the unpacked source tree dpkg-source: hint: you can integrate the local changes with dpkg-source --commit dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/pay- respects_0.6.13-1.diff.bmXGAz dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2 I: copying local configuration E: Failed autobuilding of package Test 4 (sbuild): Information only Lintian: Running lintian... N: I: pay-respects: hardening-no-fortify-functions [usr/bin/pay-respects] N: N: This package provides an ELF binary that lacks the use of fortified libc N: functions. Either there are no potentially unfortified functions called by N: any routines, all unfortified calls have already been fully validated at N: compile-time, or the package was not built with the default Debian N: compiler flags defined by dpkg-buildflags. If built using dpkg-buildflags N: directly, be sure to import CPPFLAGS. N: N: NB: Due to false-positives, Lintian ignores some unprotected functions N: (e.g. memcpy). N: N: Please refer to https://wiki.debian.org/Hardening and Bug#673112 for N: details. N: N: Visibility: info N: Show-Always: no N: Check: binaries/hardening N: N: I: pay-respects-module-request-ai: hardening-no-fortify-functions [usr/bin/_pay- respects-fallback-100-request-ai] N: I: pay-respects-module-runtime-rules: hardening-no-fortify-functions [usr/bin/_pay-respects-module-100-runtime-rules] N: I: pay-respects source: out-of-date-standards-version 4.7.0 (released 2024-04- 07) (current is 4.7.2) N: N: The source package refers to a Standards-Version older than the one that N: was current at the time the package was created (according to the N: timestamp of the latest debian/changelog entry). Please consider updating N: the package to current Policy and setting this control field N: appropriately. N: N: If the package is already compliant with the current standards, you don't N: have to re-upload the package just to adjust the Standards-Version control N: field. However, please remember to update this field next time you upload N: the package. N: N: See /usr/share/doc/debian-policy/upgrading-checklist.txt.gz in the N: debian-policy package for a summary of changes in newer versions of N: Policy. N: N: Please refer to N: https://www.debian.org/doc/debian-policy/upgrading-checklist.html for N: details. N: N: Visibility: info N: Show-Always: no N: Check: fields/standards-version N: N: I: pay-respects source: override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS [debian/rules:32] N: N: The debian/rules file for this package has an override_dh_auto_test target N: that does not appear to check DEB_BUILD_OPTIONS against nocheck. N: N: As this check is not automatically performed by debhelper(7), the N: specified testsuite is run regardless of another maintainer using the N: nocheck build option. N: N: Please add a check such as: N: N: override_dh_auto_test: N: ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) N: ./run-upstream-testsuite N: endif N: N: Lintian will ignore comments and other lines such as: N: N: # Disabled N: : Disabled N: echo "Disabled" N: mkdir foo/ N: ENV=var dh_auto_test -- ARG=value N: N: This check is not required in Debhelper compat level 13 or greater (see N: Bug#568897). N: N: Please refer to debian/rules and DEB_BUILD_OPTIONS (Section 4.9.1) in the N: Debian Policy Manual and N: https://wiki.debian.org/BuildProfileSpec#Registered_profile_names for N: details. N: N: Visibility: info N: Show-Always: no N: Check: debian/rules N: N: O: pay-respects: no-manual-page [usr/bin/pay-respects] N: N: Each binary in /usr/bin, /usr/sbin, /bin, /sbin or /usr/games should have N: a manual page N: N: Note that though the man program has the capability to check for several N: program names in the NAMES section, each of these programs should have its N: own manual page (a symbolic link to the appropriate manual page is N: sufficient) because other manual page viewers such as xman or tkman don't N: support this. N: N: If the name of the manual page differs from the binary by case, man may be N: able to find it anyway; however, it is still best practice to match the N: exact capitalization of the executable in the manual page. N: N: If the manual pages are provided by another package on which this package N: depends, Lintian may not be able to determine that manual pages are N: available. In this case, after confirming that all binaries do have manual N: pages after this package and its dependencies are installed, please add a N: Lintian override. N: N: Please refer to Manual pages (Section 12.1) in the Debian Policy Manual N: for details. N: N: Visibility: warning N: Show-Always: no N: Check: documentation/manual N: Renamed from: binary-without-manpage N: N: O: pay-respects-module-request-ai: no-manual-page [usr/bin/_pay-respects- fallback-100-request-ai] N: O: pay-respects-module-runtime-rules: no-manual-page [usr/bin/_pay-respects- module-100-runtime-rules] I: Lintian run was successful. Test 6 (debian/watch): Information only philwyett@ks-tarkin:~/Development/builder/debian/pay-respects-0.6.13$ uscan -- dehs <dehs> Newest version of pay-respects on remote site is 0.7.6, local version is 0.6.13 => Newer package available from: => https://github.com/iffse/pay-respects/archive/refs/tags/v0.7.6.tar.gz Successfully renamed ../v0.7.6.tar.gz to ../pay-respects_0.7.6.orig.tar.gz. <package>pay-respects</package> <debian-uversion>0.6.13</debian-uversion> <debian-mangled-uversion>0.6.13</debian-mangled-uversion> <upstream-version>0.7.6</upstream-version> <upstream- url>https://github.com/iffse/pay-respects/archive/refs/tags/v0.7.6.tar.gz</upstr eam-url> <status>newer package available</status> <target>pay-respects_0.7.6.orig.tar.gz</target> <target-path>../pay-respects_0.7.6.orig.tar.gz</target-path> <messages>Successfully downloaded upstream package: v0.7.6.tar.gz </messages> </dehs> Summary ======= Updated review as the package has languished in Debian Mentors for quite some time. This as usual is a solo effort. Test 1. Fails To Build From Source (FTBFS): In 'Build-Depends' section of 'debian/control'... librust-serde-yml-dev should be librust-serde-yaml-dev Test 3. Please consider looking at this issue. Test 4. Please consider looking at these issues. Test 6. Please consider updating to the latest upstream release. -- Regards Phil Donate: https://buymeacoffee.com/kathenasorg -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Internet Relay Chat (IRC): kathenas Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg Threads: https://www.threads.net/@kathenasorg --
signature.asc
Description: This is a digitally signed message part
