Control: tags -1 +moreinfo

Abhishek Deshpande,

Review of upload: 2025-05-02 07:26

For information about the tests run, see:

https://wiki.debian.org/PhilWyett/DebianMentoring

Test 4 (sbuild): Information only

Lintian:

Running lintian...
N:
P: fonts-libertinus source: trailing-whitespace [debian/control:21]
N: 
N:   This file contains lines with trailing whitespace characters.
N:   
N:   Whilst often harmless and unsightly, such extra whitespaces can also cause
N:   tools to interpret the whitespace characters literally. The tool diff(1)
N:   does not like them, either. They are best avoided.
N:   
N:   Some of these problems can be hard to track down.
N:   
N:   Whitespace at the end of lines may be removed with the following:
N:   
N:    $ sed -i -e 's@[[:space:]]*$@@g' debian/control debian/changelog
N:   
N:   If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup).
N:   
N:   However, if you wish to only remove trailing spaces and leave trailing
N:   tabs (eg. for Makefiles), you can use the following code snippet:
N:   
N:    $ sed -i -e 's@[ ]*$@@g' debian/rules
N:   
N:   To remove empty lines from the end of a file, you can use:
N:   
N:    $ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules
N: 
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: debian/trailing-whitespace
N:   Renamed from: file-contains-trailing-whitespace
N: 
N:
P: fonts-libertinus source: trailing-whitespace [debian/control:22]

I: Lintian run was successful.

Test 7 (licenserecon): Information only

philwyett@ks-tarkin:~/Development/builder/debian/fonts-libertinus-7.051$ lrc
en: Versions: licenserecon '4.2'  licensecheck '3.3.9-1'

Parsing Source Tree  ....
Reading d/copyright  ....
Running licensecheck ....

d/copyright      | licensecheck

SIL-OFL-1.1      | OFL-1.1-RFN       FONTLOG.txt
SIL-OFL-1.1      | OFL-1.1           fonts/OTF/LibertinusKeyboard-Regular.otf
SIL-OFL-1.1      | OFL-1.1           fonts/OTF/LibertinusMath-Regular.otf
SIL-OFL-1.1      | OFL-1.1           fonts/OTF/LibertinusMono-Regular.otf
SIL-OFL-1.1      | OFL-1.1           fonts/OTF/LibertinusSans-Bold.otf
SIL-OFL-1.1      | OFL-1.1           fonts/OTF/LibertinusSans-Italic.otf
SIL-OFL-1.1      | OFL-1.1           fonts/OTF/LibertinusSans-Regular.otf
SIL-OFL-1.1      | OFL-1.1           fonts/OTF/LibertinusSerif-BoldItalic.otf
SIL-OFL-1.1      | OFL-1.1           fonts/OTF/LibertinusSerif-Bold.otf
SIL-OFL-1.1      | OFL-1.1           fonts/OTF/LibertinusSerifDisplay-
Regular.otf
SIL-OFL-1.1      | OFL-1.1           fonts/OTF/LibertinusSerifInitials-
Regular.otf
SIL-OFL-1.1      | OFL-1.1           fonts/OTF/LibertinusSerif-Italic.otf
SIL-OFL-1.1      | OFL-1.1           fonts/OTF/LibertinusSerif-Regular.otf
SIL-OFL-1.1      | OFL-1.1           fonts/OTF/LibertinusSerif-
SemiboldItalic.otf
SIL-OFL-1.1      | OFL-1.1           fonts/OTF/LibertinusSerif-Semibold.otf
SIL-OFL-1.1      | OFL-1.1           OFL.txt
SIL-OFL-1.1      | OFL-1.1           sources/LibertinusKeyboard-Regular.sfd
SIL-OFL-1.1      | OFL-1.1           sources/LibertinusMono-Regular.sfd
SIL-OFL-1.1      | OFL-1.1           sources/LibertinusSerif-SemiboldItalic.sfd

Summary
=======

<Package is looking promising.

Test 4. Can we possibly fix trailing whitespace?

Test 7. Can we have a review of 'debian/copyright'? No chnages, possible changes
or adding to a 'debian/lrc.config' file.

The pre-built fonts are being copied into the package and not built. Is there a
reason for this as packages should be built from source?

-- 

Regards

Phil

Donate: https://buymeacoffee.com/kathenasorg

--

"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Internet Relay Chat (IRC): kathenas

Website: https://kathenas.org

Instagram: https://instagram.com/kathenasorg

Threads: https://www.threads.net/@kathenasorg

--




Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to