Hi Stephan,

On 05.05.25 15:05, Stephan Springl wrote:
Package: tigervnc-standalone-server
Version: 1.15.0+dfsg-1
Severity: important
Tags: upstream patch
X-Debbugs-Cc: springl...@bfw-online.de

Hi,

upstream commit 5cd38b66896c00fd56e9c54eead430d02011c38f
"Print Xvnc banner before all the usage options" changes Xvnc to print
a banner even with -inetd option rendering it useless for inetd usage.
Xvnc will output to stdout

    Xvnc TigerVNC 1.15.0 - built 2025-04-18 09:01
    Copyright (C) 1999-2025 TigerVNC team and many others (see README.rst)
    See https://www.tigervnc.org for information on TigerVNC.
    Underlying X server release 12101016

    RFB 003.008

giving a protocol error for vnc clients.  Reverting the upstream commit
makes it usable again.  The following patch is not a complete revert,
but rather fewer changes than that:

diff --git a/unix/xserver/hw/vnc/xvnc.c b/unix/xserver/hw/vnc/xvnc.c
index 09d9732..ad442c6 100644
--- a/unix/xserver/hw/vnc/xvnc.c
+++ b/unix/xserver/hw/vnc/xvnc.c
@@ -214,6 +214,8 @@ ddxInputThreadInit(void)
  void
  ddxUseMsg(void)
  {
+    vncPrintBanner();
+
      ErrorF("-pixdepths list-of-int support given pixmap depths\n");
      ErrorF("+/-render             turn on/off RENDER extension support"
             "(default on)\n");
@@ -1259,7 +1261,5 @@ vncClientGone(int fd)
  int
  main(int argc, char *argv[], char *envp[])
  {
-    vncPrintBanner();
-
      return dix_main(argc, argv, envp);
  }

I applied your fix. Please check updated package ASAP.
There might also be an unblock request needed to get the fix into Debian trixie.

Best,

Joachim Falk

Reply via email to