Bug#1104578: jabber-muc: preinst fails, calls adduser without Pre-Depend-ing on it

[Pirate Praveen]

Control: tags -1 patch

On Fri, 2 May 2025 11:24:06 +0200 Chris Hofstaedtler <z...@debian.org> wrote:

You may consider replacing adduser with a sysusers fragment, see
https://manpages.debian.org/unstable/debhelper/dh_installsysusers.1.en.html

The following debdiff should fix this bug, but I have not tested it.

diff -Nru jabber-muc-0.8/debian/changelog jabber-muc-0.8/debian/changelog
--- jabber-muc-0.8/debian/changelog     2024-12-26 21:49:21.000000000 +0000
+++ jabber-muc-0.8/debian/changelog     2025-05-04 16:21:13.000000000 +0000
@@ -1,3 +1,9 @@
+jabber-muc (0.8-10) unstable; urgency=medium
+
+  * Switch to sysusers from adduser
+
+ -- Pirate Praveen <prav...@debian.org>  Sun, 04 May 2025 21:51:13 +0530
+
 jabber-muc (0.8-9) unstable; urgency=medium
 
   * Team upload.
diff -Nru jabber-muc-0.8/debian/control jabber-muc-0.8/debian/control
--- jabber-muc-0.8/debian/control       2024-12-26 21:48:31.000000000 +0000
+++ jabber-muc-0.8/debian/control       2025-05-04 16:20:10.000000000 +0000
@@ -11,7 +11,7 @@
 
 Package: jabber-muc
 Architecture: any
-Depends: ${shlibs:Depends}, adduser, ${misc:Depends}
+Depends: ${shlibs:Depends}, ${misc:Depends}
 Recommends: jabberd2
 Description: Multi User Conference component for the Jabber IM server
  Multi User Conference component provides an implementation of XEP-0045
diff -Nru jabber-muc-0.8/debian/preinst jabber-muc-0.8/debian/preinst
--- jabber-muc-0.8/debian/preinst       2021-02-09 06:45:36.000000000 +0000
+++ jabber-muc-0.8/debian/preinst       1970-01-01 00:00:00.000000000 +0000
@@ -1,31 +0,0 @@
-#!/bin/sh
-
-set -e
-
-case "$1" in
-    upgrade)
-    ;;
-
-    install|abort-upgrade)
-    ;;
-
-    *)
-        echo "preinst called with unknown argument \`$1'" >&2
-        exit 1
-    ;;
-esac
-
-if ! getent group | grep -q "^jabber:"
-then
-   addgroup --system jabber
-fi
-
-if ! getent passwd | grep -q "^jabber:"
-then
-   adduser --system --home /var/lib/jabberd2 --no-create-home \
-   --quiet --disabled-password --ingroup jabber jabber
-fi
-
-#DEBHELPER#
-
-exit 0
diff -Nru jabber-muc-0.8/debian/sysusers jabber-muc-0.8/debian/sysusers
--- jabber-muc-0.8/debian/sysusers      1970-01-01 00:00:00.000000000 +0000
+++ jabber-muc-0.8/debian/sysusers      2025-05-04 16:19:24.000000000 +0000
@@ -0,0 +1,3 @@
+#Type Name    ID            GECOS          Home directory    Shell
+g     jabber  -             "Jabber Group" -
+u     jabber  jabber:jabber "Jabber User"  /var/lib/jabberd2

OpenPGP_0x8F53E0193B294B75.asc
Description: OpenPGP public key

OpenPGP_signature.asc

Description: OpenPGP digital signature