On Sat, 26 Apr 2025 09:42:54 +0200 Paul Gevers <elb...@debian.org> wrote:
Hi,
On Sat, 12 Apr 2025 16:18:51 +0200 Margarita Manterola
<ma...@debian.org> wrote:
> Particularly interesting is the last one, target-cpu=native. I looked
> around, trying to find where that is coming from, and found that
> upstream's .cargo/config.toml file says this:
To ensure consistency while building on Debian infrastructure, shouldn't
the Debian ecosystem ensure the tests are run for the baseline
target-cpu instead of the native cpu? With native we can get the build
to fail on some buildds and some user systems while it succeeds on
others. The build is supposed to build for the baseline anyways, so
running tests for higher than baseline doesn't add much for Debian I'd
say (except for reporting bugs upstream, but that feels like
whack-a-mole for cases like this).
Disclaimer (don't take me too serious here): as a maintainer of ci.d.n
I hate flaky tests, particularly if they are conditional on the
hardware.
IMO trying to run the doctests themselves in Debian is pointless (and
the cause of failure here). Those solely exist for upstream validating
their code against the documentation published.
I uploaded a DELAYED/5 NMU disabling doctests, which fixes this.
debdiff attached.
best,
werdahias
diff -Nru rust-safe-arch-0.7.4/debian/changelog rust-safe-arch-0.7.4/debian/changelog
--- rust-safe-arch-0.7.4/debian/changelog 2025-04-27 18:01:24.000000000 +0200
+++ rust-safe-arch-0.7.4/debian/changelog 2025-02-07 19:12:38.000000000 +0100
@@ -1,10 +1,3 @@
-rust-safe-arch (0.7.4-2.1) unstable; urgency=medium
-
- * Non-maintainer upload.
- * Add patch to skip doctests (Closes: #1081879)
-
- -- Matthias Geiger <werdah...@debian.org> Sun, 27 Apr 2025 18:01:24 +0200
-
rust-safe-arch (0.7.4-2) unstable; urgency=medium
* declare rust-related build-dependencies unconditionally,
diff -Nru rust-safe-arch-0.7.4/debian/patches/disable-doctests.diff rust-safe-arch-0.7.4/debian/patches/disable-doctests.diff
--- rust-safe-arch-0.7.4/debian/patches/disable-doctests.diff 2025-04-27 18:00:36.000000000 +0200
+++ rust-safe-arch-0.7.4/debian/patches/disable-doctests.diff 1970-01-01 01:00:00.000000000 +0100
@@ -1,19 +0,0 @@
-Description: Skip doctests altogehter since they are flaky
-Author: Matthias Geiger <werdah...@debian.org>
-Forwarded: not-needed
-Last-Update: 2025-04-27
----
-This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
-
---- a/Cargo.toml
-+++ b/Cargo.toml
-@@ -9,6 +9,9 @@
- categories = ["api-bindings", "hardware-support", "no-std"]
- keywords = ["intrinsics", "simd"]
-
-+[lib]
-+doctest = false
-+
- [dependencies]
- # If enabled, gives bytemuck trait impls for our types
- bytemuck = {version = "1.2", optional = true}
diff -Nru rust-safe-arch-0.7.4/debian/patches/series rust-safe-arch-0.7.4/debian/patches/series
--- rust-safe-arch-0.7.4/debian/patches/series 2025-04-27 17:58:20.000000000 +0200
+++ rust-safe-arch-0.7.4/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
@@ -1 +0,0 @@
-disable-doctests.diff
